Enno Rehling
5f4c31af1c
bad variable reuse leads to gcc confusion
2015-10-29 12:04:52 +01:00
Enno Rehling
8b6da79984
64 bit compatibility, thank you gcc.
2015-10-29 11:32:04 +01:00
Enno Rehling
4f25831407
coverity scan CID 22576: arguments in wrong order
...
I believe that was a false positive, and will try to aquelch it by naming the arguments better.
2015-10-29 11:24:01 +01:00
Enno Rehling
4384183ab8
coverity scan CID 22504: argument cannot be negative
...
handle error cases for ftell, just because they could happen, I guess?
2015-10-29 11:20:09 +01:00
Enno Rehling
976b6aaea1
coverity CID 22593: write to pointer after free
...
github issue #324
use free_land where we need it.
2015-10-29 11:17:31 +01:00
Enno Rehling
c298b7fd74
coverity CID 22501 imroper use of negative value
...
explicitly use SK_MAGIC instead of a lookup. Faster, easier to reason about.
2015-10-29 11:06:25 +01:00
Enno Rehling
8675002e68
coverity scan CIDs 22540 22541 22546: resource leak
...
the calendar should only ever be initialized once, but based on static analysis, I agree that this was sloppy.
2015-10-29 09:56:53 +01:00
Enno Rehling
2372d3aacd
coverity scan CID 22516: out-of-bounds write
...
potentially a bug with bad XML files? only matters if we have those, but we shouldn't
2015-10-29 09:49:26 +01:00
Enno Rehling
8b92003fff
coverity scan CID 22487: dereference after null check
...
we don't use many differnt calendars, so this has never happened.
2015-10-29 09:43:51 +01:00
Enno Rehling
e27c4b4164
coverity scan CID 22457: logically dead code
...
the original TEACH_FRIENDS feature could not possibly have worked?
2015-10-29 09:39:33 +01:00
Enno Rehling
f4c32acd05
coverity scan CID 22515: out-of-bounds access
...
increase buffer to stop coverity false positive
2015-10-29 09:32:31 +01:00
Enno Rehling
55b3bfd90e
coverity scan CID 22574: copy into fixed size buffer
...
zOrder *should* probably be big enough, but static analysis says safe is safe.
2015-10-29 09:28:02 +01:00
Enno Rehling
6ebfd33478
coverity scan CID 22503: negative array index write
2015-10-29 09:24:58 +01:00
Enno Rehling
c7aa8c89b1
coverity scan CID 22551: dereference before null check
2015-10-29 09:22:00 +01:00
Enno Rehling
4da658584c
coverity scan CID 22511: dereference null return value
2015-10-29 09:20:58 +01:00
Enno Rehling
178a740ecf
coverity scan CID 22573: copy into fixed-size buffer
...
in theory, all IDs in the game should be no longer than 4 characters, but coverity doesn't know this.
2015-10-29 09:17:23 +01:00
Enno Rehling
78899ca801
coverity scan CID 22433: buffer not null terminated, prefer strlcpy over strncpy
2015-10-29 09:06:53 +01:00
Enno Rehling
04bf07a526
coverity scan (multiple CID) is confuced about a_remove, trying to help it.
2015-10-29 09:06:52 +01:00
Enno Rehling
65429a12c3
coverity scan CID 22585, 22586: result is not floating point
2015-10-29 09:06:51 +01:00
Enno Rehling
70d4a6af03
coverity scan CID 22553: dereference before null check
2015-10-29 09:06:50 +01:00
Enno Rehling
e60b739ea4
coverity scan CID 22448: logically dead code
2015-10-29 09:06:48 +01:00
Enno Rehling
f72314e915
coverity scan CID 22451 (logically dead code)
2015-10-29 09:06:47 +01:00
Enno Rehling
6cccdec4a2
coverity scan CID 22454 (logically dead code)
2015-10-29 09:06:46 +01:00
Enno Rehling
0328e84c6c
coverity scan CID 22555: sizeof not portable
...
wrong type in sizeof (pointer instead of struct)
2015-10-29 09:06:43 +01:00
Enno Rehling
185a2ee29c
Merge pull request #321 from ennorehling/feature/fixme-base36-static
...
eliminate static variable leak and allocation from base36
2015-10-27 13:30:12 +01:00
Enno Rehling
f80f37def3
eliminate static variable leak and allocation from base36
2015-10-27 12:48:34 +01:00
Enno Rehling
feb915fe4a
eliminate deprecated reporting function, static variable
2015-10-27 12:40:04 +01:00
Enno Rehling
e3572ef14e
eliminate deprecated call
2015-10-27 12:40:04 +01:00
Enno Rehling
e23a7fc87d
deprecate report_kampfstatus and implement a replacement function.
2015-10-27 12:40:04 +01:00
Enno Rehling
f2b0ba1ec6
eliminate find_spell warning for games where nobody is cursed, and you cannot summon igjarjuk
2015-10-27 12:40:03 +01:00
Enno Rehling
b771ec9aab
test-only leak: do some json surgery and delete the entire tree from the export
2015-10-15 09:06:44 +02:00
Enno Rehling
47e925473e
always use a macro, not magical constants
2015-10-15 08:40:52 +02:00
Enno Rehling
c9e7a76d9b
minor leak: release memory held by curse_type structures
2015-10-15 08:38:43 +02:00
Enno Rehling
d4655ee88a
leak: do not create new message_type objects in test_cleanup
2015-10-15 08:29:20 +02:00
Enno Rehling
d79745812a
unit needs to be in a region or test_cleanup will not free it
2015-10-14 22:19:15 +02:00
Enno Rehling
467ce2a719
visual studio compilation fix
2015-10-14 22:09:11 +02:00
Enno Rehling
ef1a2dfc4f
fixed a crash
2015-10-14 22:06:40 +02:00
Enno Rehling
3200dd2dc8
leak: free locale_data
2015-10-14 21:51:43 +02:00
Enno Rehling
b5455531e7
do not leak terrain.herbs
2015-10-14 21:37:27 +02:00
Enno Rehling
c04bda102b
call free_order for each remaining reference
2015-10-14 20:56:09 +02:00
Enno Rehling
a3b27ad6d2
leak: remember to call test_cleanup
2015-10-14 20:49:30 +02:00
Enno Rehling
03ff8f612d
leaks: remember to call test_cleanup
2015-10-14 20:48:01 +02:00
Enno Rehling
284a74c878
leak: deleting a config entry did not free its name
2015-10-14 20:45:43 +02:00
Enno Rehling
f740f2829a
leak: in tests, when correct message_type doesn't exist, arguments should not leak
2015-10-14 20:41:42 +02:00
Enno Rehling
144aeb23ac
leaks: call cleanup, free triggers
2015-10-14 20:29:07 +02:00
Enno Rehling
0f32630590
leak: release message in test
2015-10-14 20:22:51 +02:00
Enno Rehling
5018bbb0c0
correctly release messages created in test_merge_split
2015-10-14 20:21:38 +02:00
Enno Rehling
203b058166
avoid memory leaks when running with --list
2015-10-14 20:04:03 +02:00
Enno Rehling
47eee29813
correct argument count
2015-10-14 18:40:37 +02:00
Enno Rehling
5d192cb4c9
fix compile: gcc is extra picky about const char** conversions.
2015-10-14 18:38:10 +02:00
Enno Rehling
ba0828afd4
rather complex implementation of selective test running (CuTest does not have this feature).
2015-10-14 18:34:41 +02:00
Enno Rehling
e6f2864327
leak: duplicate assignment to building_type.name in tests
2015-10-14 14:10:35 +02:00
Enno Rehling
2abdba9e8a
refactor free_messagelist, fix leak in test_merge_split
2015-10-14 14:08:50 +02:00
Enno Rehling
1c2922aafa
leak: spell names and other strings need to be released.
2015-10-14 13:58:55 +02:00
Enno Rehling
5f9c2e13a8
I hate umlaut.c, it's basically magic, and the magic doesn't work right (it leaks memory from line 158)
2015-10-14 13:56:19 +02:00
Enno Rehling
cd9cb24b48
extend test_umlaut a bit, which doesn't trigger issue #316
2015-10-14 13:42:12 +02:00
Enno Rehling
78a8795305
there is a bug in umlaut.c, adding a FIXME.
...
this happens during test_umlaut, and valgrind detects it.
2015-10-14 13:33:10 +02:00
Enno Rehling
254cda86e8
short commands speedup wasn't working (never got assigned)
2015-10-14 13:20:27 +02:00
Enno Rehling
4fc5ac7740
there is a memory leak in test_long_order_hungry, but the root cause lies deeper
2015-10-14 12:51:45 +02:00
Enno Rehling
469d312339
leak: test must free castorder and call cleanup
2015-10-14 12:23:58 +02:00
Enno Rehling
bdf4834dc2
leak: region_owner data was never released
2015-10-14 12:22:37 +02:00
Enno Rehling
8e9e9c9c0f
eliminate leak from duplicate call to test_create_buildingtype
2015-10-14 12:21:13 +02:00
Enno Rehling
ae3210ec87
pervious commit did not compile: small copy/paste error
2015-10-14 12:14:33 +02:00
Enno Rehling
2c659c1f47
memory leak: free building maintenance data
2015-10-14 12:13:05 +02:00
Enno Rehling
1fc5273f63
memory leak: bad call to register_buildings, replace test_create_world.
2015-10-14 12:09:35 +02:00
Enno Rehling
2b59922d8d
memory leak: tests should call cleanup instead of trying to restore original state
2015-10-14 12:05:29 +02:00
Enno Rehling
acda22ae1b
leak: free route at the end of the test
2015-10-14 12:03:19 +02:00
Enno Rehling
3cfb22876b
memory leak: free params after test
2015-10-14 12:01:33 +02:00
Enno Rehling
20c9fb60dc
release additional reference to recruit order
2015-10-14 11:58:54 +02:00
Enno Rehling
f0671aafda
leak: some tests were leaking seen_factions becaus they don't call destroyfaction or render reports
2015-10-13 23:33:11 +02:00
Enno Rehling
66dd7e2320
eliminate unused variable warning (gcc)
2015-10-13 23:27:13 +02:00
Enno Rehling
a3210aaed7
leak: free per-locale cached order data (has additional refcount)
2015-10-13 23:25:44 +02:00
Enno Rehling
377b0d0305
leak: teardown build tests, free construction data
2015-10-13 23:09:50 +02:00
Enno Rehling
f4f038c23c
leak: free strlist result of split_paragraph
2015-10-13 23:06:33 +02:00
Enno Rehling
24f1f82e93
release order reference used to create castorder, message
2015-10-13 23:02:01 +02:00
Enno Rehling
a6ca489d9a
free multi-level construction correctly, avoid duplication
2015-10-13 22:56:16 +02:00
Enno Rehling
26f5b592bd
leak: free construction materials
2015-10-13 22:41:54 +02:00
Enno Rehling
457465b4a2
memory leak: free message_list objects
2015-10-13 22:37:45 +02:00
Enno Rehling
333c27403f
memory leaks: ship_type.construction, give_cmd return values
2015-10-13 22:34:22 +02:00
Enno Rehling
cd1467f668
cleanup: test_create_world is lazy
2015-10-13 22:31:03 +02:00
Enno Rehling
c70d987c09
memory leak: free weapon data
2015-10-13 22:27:43 +02:00
Enno Rehling
0facb386a8
memory leaks: call test_cleanup, free strlist, free message
2015-10-13 22:21:05 +02:00
Enno Rehling
d264c454b8
memory leak: building_type::construction was never released
2015-10-13 22:13:50 +02:00
Enno Rehling
1f1850dafc
memory leak: always cleanup at the end of a test that creates game data.
2015-10-13 22:11:45 +02:00
Enno Rehling
7c2c520911
memory leak: at_travelunit contains a quicklist, needs custom cleanup code.
2015-10-13 22:09:41 +02:00
Enno Rehling
7e9c36b599
memory leak: free spell components and spells at exit
2015-10-13 22:02:58 +02:00
Enno Rehling
67135c8ea3
avoid triggering null-pointer assert
2015-10-13 21:50:23 +02:00
Enno Rehling
2f35246f8c
memory leak: when freeing factions, also free their spellbooks
2015-10-13 21:47:45 +02:00
Enno Rehling
ff0bbce4f9
weird things happen when you name locales something else?
2015-10-13 21:30:10 +02:00
Enno Rehling
9f6fa5b948
Merge branch 'feature/tests-leaks' of github.com:ennorehling/eressea into feature/tests-leaks
2015-10-13 21:26:56 +02:00
Enno Rehling
6de8e4466a
stop memory leak from function registry.
2015-10-13 21:26:48 +02:00
Enno Rehling
3741a19437
prevent memory leak of cJSON structures in tests
2015-10-13 21:21:31 +02:00
Enno Rehling
422476409c
eliminate memory leak from locales
2015-10-13 20:58:03 +02:00
Enno Rehling
5c8a68e1de
always call seen_done to eliminate memory leaks in tests.
2015-10-13 16:05:32 +02:00
Enno Rehling
7854684d8b
fix memory leaks in all tests that create an order without calling free_order at the end.
2015-10-13 15:45:38 +02:00
Enno Rehling
96be12218e
test rename with missing name (not crashing, error message)
2015-10-13 14:27:42 +02:00
Enno Rehling
6de604701d
add some test coverage for name_cmd (not covering all error cases yet)
2015-10-13 13:56:58 +02:00
Enno Rehling
177f8f5288
re-enable a test that supposedly breaks on travis (find out why)
...
fix a potential null-pointer crash in rename_cmd
2015-10-13 13:32:27 +02:00
Enno Rehling
7e2364c296
test for actual piracy ship movement
...
refactor storm check, run less code when disabled
fix ship creation in tests
2015-10-12 19:40:20 +02:00
Enno Rehling
d252286f4c
refactor: extract function parse_ids for readability
2015-10-12 18:54:47 +02:00
Enno Rehling
4c028bceac
the early beginnings of a test for piracy
...
extract validation message from piracy_cmd
fix a SAIL/SWIM check inconsistency
2015-10-12 16:30:56 +02:00
Enno Rehling
dcf6c28b0e
testing all the error cases for PIRACY
2015-10-12 13:27:39 +02:00
Enno Rehling
678169d7d4
add skeleton test suite for piracy
2015-10-12 11:54:59 +02:00
Enno Rehling
521519805d
refactor piracy code into a module, separate from move.
2015-10-11 21:19:38 +02:00
Enno Rehling
936c201d0b
Merge pull request #312 from eressea/master
...
pull latest changes from master into develop
2015-10-11 16:47:29 +02:00
Enno Rehling
6a074fd294
only disable MSVC2015 warnings in MSVC2015, do not break confuse compilers.
2015-10-11 14:39:51 +02:00
Enno Rehling
e8880db447
get the code to compile under vs2015 (disable warnings)
2015-10-11 14:39:43 +02:00
Enno Rehling
c47c9dbf64
add mail_cmd tests for FACTION
2015-10-11 12:54:27 +02:00
Enno Rehling
403b8a2e7e
add mail_cmd tests for REGION
2015-10-11 12:44:22 +02:00
Enno Rehling
070ed1a941
clean up hastily written tests, eliminate duplicate code
2015-10-11 12:38:05 +02:00
Enno Rehling
9e49e10d11
Merge branch 'master' into develop
...
Conflicts:
src/buildno.h
src/kernel/unit.test.c
2015-10-10 22:55:29 +02:00
Enno Rehling
99c385412a
fix crash in mail_cmd when order is missing a message
2015-10-10 22:50:15 +02:00
Enno Rehling
7f81cee36d
Merge pull request #305 from ennorehling/feature/log-reduce
...
reduced log spam in cron emails
2015-09-28 12:27:04 +02:00
Enno Rehling
3eead446d0
reduce cron log spam
2015-09-26 22:42:22 +02:00
Enno Rehling
d153846769
test: ageing ship trails works as expected. cannot find a bug here.
...
Conflicts:
src/move.test.c
2015-09-25 14:10:25 +02:00
Enno Rehling
f07802bab5
add a test to check that move_ship creates a trail when given a route
...
Conflicts:
src/move.test.c
2015-09-25 14:09:22 +02:00
Enno Rehling
f018016feb
rename hunt to follow_ship, because why was it ever called anything else?
2015-09-25 14:06:18 +02:00
Enno Rehling
ae513c5f23
Merge branch 'hotfix/bug-2138-familiarmage' of github.com:ennorehling/eressea into hotfix/bug-2138-familiarmage
2015-09-23 18:31:46 +02:00
Enno Rehling
1028539adb
version number increase
2015-09-23 18:29:18 +02:00
Enno Rehling
84a92124bd
Merge branch 'feature/bug-2053-attack-monsters' of https://github.com/ennorehling/eressea into ennorehling-feature/bug-2053-attack-monsters
...
Conflicts:
conf/e3/config.xml
2015-09-19 13:35:53 +02:00
Enno Rehling
e217a4b550
age_unit accidentally returned AT_AGE_REMOVE (caused by a recent change to curse_age)
2015-09-14 22:58:12 +02:00
Enno Rehling
3a1444f378
backport (failing) at_familiarmage test from 3.7 branch
2015-09-14 17:38:58 +02:00
Enno Rehling
23a7ed59ac
backport familiar skill test from 3.7 development
2015-09-14 17:17:29 +02:00
Enno Rehling
90bcf30628
fix bad terrain definitions in E2 (string, not number: these values are used for dice throws).
...
clean up the jsonconf.c code for reading these a little bit, report more specific errors.
2015-09-13 09:46:40 +02:00
Enno Rehling
71c4cb53c0
add missing guard.h include everywhere, remove duplicate prototypes from config.h
2015-09-12 23:41:37 +02:00
Enno Rehling
dd9420fc38
move at_guard into guard module as well
2015-09-12 23:38:31 +02:00
Enno Rehling
3055f517dc
move guard implementation into a module (WIP)
2015-09-12 22:53:54 +02:00
Enno Rehling
5f7b9129bc
Merge branch 'master' into develop
...
Conflicts:
tests/runtests.bat
2015-09-12 22:47:33 +02:00
Enno Rehling
a027139057
remove global variable verbosity
in favor of static in main.c (use log_* functions everywhere)
2015-09-12 20:58:09 +02:00
Enno Rehling
06a04d0e20
fix logging for sp_igjarjuk, temporarily set log-levels for the game to error|warn|info
...
remove some code that accesses `verbosity` variable (todo: hide it more, fix logging)
2015-09-12 19:48:03 +02:00
Enno Rehling
63c983e197
Merge branch 'develop' of github.com:eressea/server into develop
2015-09-12 19:28:49 +02:00
Enno Rehling
c7a0fb5f28
development build is 3.7
2015-09-12 19:28:28 +02:00
Enno Rehling
44dd66f2fb
Merge branch 'master' into develop
2015-09-12 19:27:56 +02:00
Enno Rehling
28f17b6a08
release version 3.6.3
2015-09-12 19:27:11 +02:00
Enno Rehling
7259a4b45e
remove parse_main from xmlreader, everything superseeded by jsonconf
2015-09-12 18:16:23 +02:00
Enno Rehling
1e75255d51
allow disabling skills through json
2015-09-12 17:43:31 +02:00
Enno Rehling
a01955e06a
disable features by name that are not keywords
2015-09-12 17:37:29 +02:00
Enno Rehling
c76b118fb8
eliminate game/order from XML data
2015-09-12 17:12:02 +02:00
Enno Rehling
44eb3a4f58
disable keywords through JSON configuration
2015-09-12 17:06:55 +02:00
Enno Rehling
32ff7c89bc
Merge pull request #296 from ennorehling/feature/config-producexpchance
...
Bug 2137: calculating produceexp correctly
2015-09-12 16:52:55 +02:00
Enno Rehling
7906cdbcb6
do not read gamename from XML, read it from JSON only (two mechanisms for the same feature are too many)
2015-09-12 16:49:18 +02:00
Enno Rehling
d65e9aaf94
eliminate xml reading of produceexp chance
2015-09-12 16:42:02 +02:00
Enno Rehling
8a95ea0c00
speeding up produceexp_chance
2015-09-12 16:41:22 +02:00
Enno Rehling
9bdc811582
produceexp uses a json-configurable constant
...
make get_param_flt return a double, floats are for wimps.
2015-09-12 16:38:51 +02:00
Enno Rehling
68c448b3fb
fix signature of callback
2015-09-12 16:29:57 +02:00
Enno Rehling
d1686849e0
refactoring: move produceexp into unit module, for want of a better one. add a bit of test coverage.
...
https://bugs.eressea.de/view.php?id=2137 - fix learning-by-doing with less than u->number people.
2015-09-12 16:25:47 +02:00
Enno Rehling
c704cd5784
release version 3.6.2
2015-09-12 15:41:25 +02:00
Enno Rehling
9563aa712f
eliminate junk function
2015-09-12 14:16:18 +02:00
Enno Rehling
42f1030251
separate test script for E4:
...
even though it has mostly the same rules, it does not have xmastrees, and loads a different config
remove dead `inactivefaction` function, we have no use for the file it creates.
2015-09-12 14:10:08 +02:00
Enno Rehling
aa32cf190e
remove xmlreader code for prefixes
2015-09-12 13:40:10 +02:00
Enno Rehling
09efd9c2a9
fix anything that uses the calendar module. opps.
2015-09-12 12:54:49 +02:00
Enno Rehling
13e1573611
moving the calendar module out of the kernel directory, it does not belong with the major game objects
2015-09-12 12:54:09 +02:00
Enno Rehling
47c95aee35
implement JSON prefixes. fix free_prefixes not resetting size (TODO: quicklist).
2015-09-12 12:49:12 +02:00
Enno Rehling
f0e255924f
add a unit test for add/free prefixes. fix bad free_prefixes call site.
2015-09-12 12:41:04 +02:00
Enno Rehling
9f6b374056
add a (red) test for JSON prefixes.
2015-09-12 12:33:25 +02:00
Enno Rehling
44d982d210
free race prefixes when the game is done (small memory leak).
2015-09-12 12:29:42 +02:00
Enno Rehling
f1476c2167
refactoring: split out a module for race prefixes
2015-09-12 12:24:10 +02:00
Enno Rehling
bd51ac7dd7
eliminate terrain parsing from xmlreader.c, it's all in JSON now!
2015-09-11 22:46:47 +02:00
Enno Rehling
c57918ede0
replace XML terrains for E3 and E4 with JSON configuration
2015-09-11 22:43:08 +02:00
Enno Rehling
b4971dd651
replace all of the E2 terrains with JSON data (no more XML!)
2015-09-11 22:11:59 +02:00
Enno Rehling
7c4d18ec2d
avoid an annoying division by zero when terrains are not fully initialized (size=0)
2015-09-11 21:31:59 +02:00
Enno Rehling
db4cb2618b
transfer most core and all game-specific terrains for E2 from XML to JSON.
2015-09-11 21:14:10 +02:00
Enno Rehling
9df5799efd
define core plain and ocean in JSON for E2.
2015-09-11 12:52:18 +02:00
Enno Rehling
a582c69523
finished and tested: terrains can be completely defined in JSON.
2015-09-11 12:27:45 +02:00
Enno Rehling
43bac506a4
fix bad size for calloc.
2015-09-11 12:25:28 +02:00
Enno Rehling
c707ff39b6
memory leak: properly free terrain_production objects
2015-09-11 12:17:35 +02:00
Enno Rehling
59e2c12605
completing the implementation of JSON terrains (WIP).
...
seeing a crash when trying to allocate a resource for stone in test_json_terrains.
2015-09-11 12:12:53 +02:00
Enno Rehling
8860244f1c
Merge branch 'link-seen-duplicate' into feature/feature-json-terrains
2015-09-11 11:12:30 +02:00
Enno Rehling
d15d0cc0f4
remove unused xml_i function
2015-09-11 11:08:10 +02:00
Enno Rehling
cf08cdf3fb
configuration type-fixes: int to bool where appropriate (possibly incomplete)
...
rename some rules to make it more obvious that they are flags or other integer values.
2015-09-11 10:04:08 +02:00
Enno Rehling
c5e14c85a6
read boolean json values
...
be smarter about reading number values that are integers
2015-09-11 09:17:07 +02:00
Enno Rehling
9bb2a625f9
fix xmlreader bug introduced by last commit (xpath->node not initialized)
2015-09-11 09:10:00 +02:00
Enno Rehling
1a7d6dd91d
xmlreader no longer needs to parse settings, that's all in json now.
2015-09-10 23:29:18 +02:00
Enno Rehling
1969c165d3
allow settings in json configuration file
...
move E2 settings from XML to JSON
2015-09-10 23:16:17 +02:00
Enno Rehling
2b46c4c4a9
kill stray semicolon
2015-09-10 21:22:55 +02:00
Enno Rehling
f2b2dc2063
fix linux build, missing include
2015-09-09 16:48:24 +02:00
Enno Rehling
337aca9b3c
remove region.donations, replace with a global list.
2015-09-09 16:47:09 +02:00
Enno Rehling
d29d38f710
refactor donations into a seaprate code module, add a basic test
2015-09-09 15:45:20 +02:00
Enno Rehling
60111282b3
make findunitr be O(1) instead of O(#r->units)
2015-09-09 13:29:58 +02:00
Enno Rehling
5faf642b9c
use the same DISABLE_TEST macro everywhere.
2015-09-09 13:23:20 +02:00
Enno Rehling
6f212686f3
Merge pull request #287 from ennorehling/feature/issue-282-link-seen
...
eliminate duplicate call to link_seen
2015-09-09 12:41:14 +02:00
Enno Rehling
bf6f05f39d
fix unused variable warning
2015-09-09 11:24:11 +02:00
Enno Rehling
cac22bcb02
Merge branch 'feature/issue-282-link-seen' of github.com:ennorehling/eressea into feature/issue-282-link-seen
2015-09-09 11:23:15 +02:00
Enno Rehling
f7c1efc287
memory error seems to be in test_write_flag (curse-hashing?), not in the new ones.
2015-09-09 11:22:35 +02:00
Enno Rehling
e5a92d6313
building on linux
2015-09-09 11:09:57 +02:00
Enno Rehling
65c39866e1
refactor: add a faction_add_seen function that also updates [first, last) interval.
...
add tests for add_seen.
disable test_faction_add_seen, looks like it needs a valgrind check?
2015-09-09 11:08:33 +02:00
Enno Rehling
7f9e84d68b
fix neighbor seen_region collection.
2015-09-09 10:22:04 +02:00
Enno Rehling
42e51a0ec4
refactor looping through the hashtable of seen_regions into a map function.
2015-09-09 09:38:57 +02:00
Enno Rehling
3eabf082ac
refactor prepare_report to extract prepare_seen, because we assume the bug is in there.
...
add a failing test for it to prove that bug is in here.
2015-09-09 09:04:59 +02:00
Enno Rehling
b551261b66
fix the bug that the unit test exposed. it was so simple!
...
still not fixing the integration test, though :-(
2015-09-08 16:35:18 +02:00
Enno Rehling
1fbbba564b
add a unit test for the problem that fails (test_seen_interval_forward)
2015-09-08 16:28:47 +02:00
Enno Rehling
2e0482973e
testing test_seen_interval
2015-09-08 10:17:01 +02:00
Enno Rehling
8562a6d072
add test suite for seen_region logic (empty)
2015-09-08 10:07:29 +02:00
Enno Rehling
9312b44f8e
move seen_region logic to a separate seen.[hc] module for testing.
...
currently failing test:
1) Failure (tests.report.test_lighthouse):
./scripts/tests/common.lua:1051: true expected but was false
2015-09-08 09:56:56 +02:00
Enno Rehling
d64948f0fc
eliminate duplicate call to link_seen (and report_context.seen)
2015-09-07 19:48:53 +02:00
Enno Rehling
77912166bf
Backfill missing tests for Bug 1818. Actual bug appears to have been fixed some time ago.
2015-09-07 14:49:57 +02:00
Enno Rehling
34580ab9fa
fix test requiring a data directory (sigsegv)
2015-09-06 20:07:15 +02:00
Enno Rehling
f84133eb53
fix linux builds
2015-09-06 19:08:57 +02:00
Enno Rehling
b8df3f3a5f
increase the datatype for scores from int to long long
...
this fixes https://bugs.eressea.de/view.php?id=2136
2015-09-06 19:04:04 +02:00
Enno Rehling
19e27930ab
Merge remote-tracking branch 'upstream/master' into develop
...
Conflicts:
.travis.yml
scripts/eressea/cursed.lua
2015-09-06 13:28:08 +02:00