Enno Rehling
|
f959f43f1e
|
extensive tests for armor calculation
|
2015-11-03 18:59:09 +01:00 |
|
Enno Rehling
|
91a6324a97
|
cleanup: functions do not need to be dereferenced with an & in C.
|
2015-11-03 13:30:34 +01:00 |
|
Enno Rehling
|
7e81b98fa4
|
Merge pull request #339 from TurnerSE/improvement/CID22481
Improvement/cid22481
|
2015-11-03 13:08:03 +01:00 |
|
Philipp Dreher
|
07fd3dc970
|
formal correction
|
2015-11-02 18:06:19 +01:00 |
|
Enno Rehling
|
072bfd3912
|
testin building_is_active
testing multiple units in one building
|
2015-11-02 15:06:30 +01:00 |
|
Enno Rehling
|
4bf2509fb3
|
test inside_building vs. overflow
fix default building capacity (should be 1 per size)
|
2015-11-02 14:56:58 +01:00 |
|
Enno Rehling
|
42ae086def
|
unit is inisde a building also when it was not paid for
|
2015-11-02 14:49:48 +01:00 |
|
Enno Rehling
|
24ff4c301d
|
refactor: separate building_is_active from inside_building
|
2015-11-02 14:18:50 +01:00 |
|
Philipp Dreher
|
b107ddadf5
|
added assert to check the faction-pointer
|
2015-11-01 21:43:18 +01:00 |
|
Philipp Dreher
|
491e5faed9
|
Revert "general check for sf->faction's validity"
This reverts commit f18b5ea7d2.
|
2015-11-01 21:40:06 +01:00 |
|
Philipp Dreher
|
f18b5ea7d2
|
general check for sf->faction's validity
The handling of an ally without a valid faction-pointer is now skipped
in favor of a logged error.
|
2015-11-01 18:54:29 +01:00 |
|
Enno Rehling
|
21a2313e2a
|
CID 22517: Parse warning (PW.PARAM_SET_BUT_NOT_USED)
|
2015-10-30 15:20:06 +01:00 |
|
Enno Rehling
|
e7ca5345d7
|
CID 22509: Dereference null return value (NULL_RETURNS)
potential problems at the edge of the map.
|
2015-10-30 12:57:07 +01:00 |
|
Enno Rehling
|
e1eb5098d4
|
CID 22554: Improper use of negative value (REVERSE_NEGATIVE)
I believe this was a false positive, but more asserts can never hurt.
|
2015-10-30 12:40:48 +01:00 |
|
Enno Rehling
|
93b7bacff5
|
CID 22552: Dereference before null check (REVERSE_INULL)
|
2015-10-30 12:37:27 +01:00 |
|
Enno Rehling
|
5d273e475e
|
CID 22558: Copy into fixed size buffer (STRING_OVERFLOW)
bsdstring buffer size check
|
2015-10-30 11:41:59 +01:00 |
|
Enno Rehling
|
1fb04179dc
|
CID 22557: Copy into fixed size buffer (STRING_OVERFLOW)
eliminate code duplication. bsdstring is better than libc strings.
|
2015-10-30 11:39:47 +01:00 |
|
Enno Rehling
|
4eb6a89821
|
CID 26262: short and unsigned types are the devil, use int everywhere for fewer headaches
|
2015-10-29 20:39:44 +01:00 |
|
Enno Rehling
|
4f25831407
|
coverity scan CID 22576: arguments in wrong order
I believe that was a false positive, and will try to aquelch it by naming the arguments better.
|
2015-10-29 11:24:01 +01:00 |
|
Enno Rehling
|
976b6aaea1
|
coverity CID 22593: write to pointer after free
github issue #324
use free_land where we need it.
|
2015-10-29 11:17:31 +01:00 |
|
Enno Rehling
|
c298b7fd74
|
coverity CID 22501 imroper use of negative value
explicitly use SK_MAGIC instead of a lookup. Faster, easier to reason about.
|
2015-10-29 11:06:25 +01:00 |
|
Enno Rehling
|
8675002e68
|
coverity scan CIDs 22540 22541 22546: resource leak
the calendar should only ever be initialized once, but based on static analysis, I agree that this was sloppy.
|
2015-10-29 09:56:53 +01:00 |
|
Enno Rehling
|
2372d3aacd
|
coverity scan CID 22516: out-of-bounds write
potentially a bug with bad XML files? only matters if we have those, but we shouldn't
|
2015-10-29 09:49:26 +01:00 |
|
Enno Rehling
|
8b92003fff
|
coverity scan CID 22487: dereference after null check
we don't use many differnt calendars, so this has never happened.
|
2015-10-29 09:43:51 +01:00 |
|
Enno Rehling
|
70d4a6af03
|
coverity scan CID 22553: dereference before null check
|
2015-10-29 09:06:50 +01:00 |
|
Enno Rehling
|
f2b0ba1ec6
|
eliminate find_spell warning for games where nobody is cursed, and you cannot summon igjarjuk
|
2015-10-27 12:40:03 +01:00 |
|
Enno Rehling
|
47e925473e
|
always use a macro, not magical constants
|
2015-10-15 08:40:52 +02:00 |
|
Enno Rehling
|
c9e7a76d9b
|
minor leak: release memory held by curse_type structures
|
2015-10-15 08:38:43 +02:00 |
|
Enno Rehling
|
d4655ee88a
|
leak: do not create new message_type objects in test_cleanup
|
2015-10-15 08:29:20 +02:00 |
|
Enno Rehling
|
467ce2a719
|
visual studio compilation fix
|
2015-10-14 22:09:11 +02:00 |
|
Enno Rehling
|
ef1a2dfc4f
|
fixed a crash
|
2015-10-14 22:06:40 +02:00 |
|
Enno Rehling
|
3200dd2dc8
|
leak: free locale_data
|
2015-10-14 21:51:43 +02:00 |
|
Enno Rehling
|
b5455531e7
|
do not leak terrain.herbs
|
2015-10-14 21:37:27 +02:00 |
|
Enno Rehling
|
c04bda102b
|
call free_order for each remaining reference
|
2015-10-14 20:56:09 +02:00 |
|
Enno Rehling
|
a3b27ad6d2
|
leak: remember to call test_cleanup
|
2015-10-14 20:49:30 +02:00 |
|
Enno Rehling
|
03ff8f612d
|
leaks: remember to call test_cleanup
|
2015-10-14 20:48:01 +02:00 |
|
Enno Rehling
|
284a74c878
|
leak: deleting a config entry did not free its name
|
2015-10-14 20:45:43 +02:00 |
|
Enno Rehling
|
f740f2829a
|
leak: in tests, when correct message_type doesn't exist, arguments should not leak
|
2015-10-14 20:41:42 +02:00 |
|
Enno Rehling
|
144aeb23ac
|
leaks: call cleanup, free triggers
|
2015-10-14 20:29:07 +02:00 |
|
Enno Rehling
|
5018bbb0c0
|
correctly release messages created in test_merge_split
|
2015-10-14 20:21:38 +02:00 |
|
Enno Rehling
|
2abdba9e8a
|
refactor free_messagelist, fix leak in test_merge_split
|
2015-10-14 14:08:50 +02:00 |
|
Enno Rehling
|
1c2922aafa
|
leak: spell names and other strings need to be released.
|
2015-10-14 13:58:55 +02:00 |
|
Enno Rehling
|
254cda86e8
|
short commands speedup wasn't working (never got assigned)
|
2015-10-14 13:20:27 +02:00 |
|
Enno Rehling
|
4fc5ac7740
|
there is a memory leak in test_long_order_hungry, but the root cause lies deeper
|
2015-10-14 12:51:45 +02:00 |
|
Enno Rehling
|
bdf4834dc2
|
leak: region_owner data was never released
|
2015-10-14 12:22:37 +02:00 |
|
Enno Rehling
|
ae3210ec87
|
pervious commit did not compile: small copy/paste error
|
2015-10-14 12:14:33 +02:00 |
|
Enno Rehling
|
2c659c1f47
|
memory leak: free building maintenance data
|
2015-10-14 12:13:05 +02:00 |
|
Enno Rehling
|
3cfb22876b
|
memory leak: free params after test
|
2015-10-14 12:01:33 +02:00 |
|
Enno Rehling
|
f0671aafda
|
leak: some tests were leaking seen_factions becaus they don't call destroyfaction or render reports
|
2015-10-13 23:33:11 +02:00 |
|
Enno Rehling
|
a3210aaed7
|
leak: free per-locale cached order data (has additional refcount)
|
2015-10-13 23:25:44 +02:00 |
|
Enno Rehling
|
377b0d0305
|
leak: teardown build tests, free construction data
|
2015-10-13 23:09:50 +02:00 |
|
Enno Rehling
|
a6ca489d9a
|
free multi-level construction correctly, avoid duplication
|
2015-10-13 22:56:16 +02:00 |
|
Enno Rehling
|
26f5b592bd
|
leak: free construction materials
|
2015-10-13 22:41:54 +02:00 |
|
Enno Rehling
|
457465b4a2
|
memory leak: free message_list objects
|
2015-10-13 22:37:45 +02:00 |
|
Enno Rehling
|
333c27403f
|
memory leaks: ship_type.construction, give_cmd return values
|
2015-10-13 22:34:22 +02:00 |
|
Enno Rehling
|
c70d987c09
|
memory leak: free weapon data
|
2015-10-13 22:27:43 +02:00 |
|
Enno Rehling
|
0facb386a8
|
memory leaks: call test_cleanup, free strlist, free message
|
2015-10-13 22:21:05 +02:00 |
|
Enno Rehling
|
d264c454b8
|
memory leak: building_type::construction was never released
|
2015-10-13 22:13:50 +02:00 |
|
Enno Rehling
|
7e9c36b599
|
memory leak: free spell components and spells at exit
|
2015-10-13 22:02:58 +02:00 |
|
Enno Rehling
|
67135c8ea3
|
avoid triggering null-pointer assert
|
2015-10-13 21:50:23 +02:00 |
|
Enno Rehling
|
2f35246f8c
|
memory leak: when freeing factions, also free their spellbooks
|
2015-10-13 21:47:45 +02:00 |
|
Enno Rehling
|
3741a19437
|
prevent memory leak of cJSON structures in tests
|
2015-10-13 21:21:31 +02:00 |
|
Enno Rehling
|
7854684d8b
|
fix memory leaks in all tests that create an order without calling free_order at the end.
|
2015-10-13 15:45:38 +02:00 |
|
Enno Rehling
|
7f81cee36d
|
Merge pull request #305 from ennorehling/feature/log-reduce
reduced log spam in cron emails
|
2015-09-28 12:27:04 +02:00 |
|
Enno Rehling
|
3eead446d0
|
reduce cron log spam
|
2015-09-26 22:42:22 +02:00 |
|
Enno Rehling
|
84a92124bd
|
Merge branch 'feature/bug-2053-attack-monsters' of https://github.com/ennorehling/eressea into ennorehling-feature/bug-2053-attack-monsters
Conflicts:
conf/e3/config.xml
|
2015-09-19 13:35:53 +02:00 |
|
Enno Rehling
|
90bcf30628
|
fix bad terrain definitions in E2 (string, not number: these values are used for dice throws).
clean up the jsonconf.c code for reading these a little bit, report more specific errors.
|
2015-09-13 09:46:40 +02:00 |
|
Enno Rehling
|
71c4cb53c0
|
add missing guard.h include everywhere, remove duplicate prototypes from config.h
|
2015-09-12 23:41:37 +02:00 |
|
Enno Rehling
|
dd9420fc38
|
move at_guard into guard module as well
|
2015-09-12 23:38:31 +02:00 |
|
Enno Rehling
|
3055f517dc
|
move guard implementation into a module (WIP)
|
2015-09-12 22:53:54 +02:00 |
|
Enno Rehling
|
8fa3234159
|
Merge branch 'master' into develop
Conflicts:
tests/runtests.bat
|
2015-09-12 21:00:28 +02:00 |
|
Enno Rehling
|
a027139057
|
remove global variable verbosity in favor of static in main.c (use log_* functions everywhere)
|
2015-09-12 20:58:09 +02:00 |
|
Enno Rehling
|
06a04d0e20
|
fix logging for sp_igjarjuk, temporarily set log-levels for the game to error|warn|info
remove some code that accesses `verbosity` variable (todo: hide it more, fix logging)
|
2015-09-12 19:48:03 +02:00 |
|
Enno Rehling
|
7259a4b45e
|
remove parse_main from xmlreader, everything superseeded by jsonconf
|
2015-09-12 18:16:23 +02:00 |
|
Enno Rehling
|
1e75255d51
|
allow disabling skills through json
|
2015-09-12 17:43:31 +02:00 |
|
Enno Rehling
|
a01955e06a
|
disable features by name that are not keywords
|
2015-09-12 17:37:29 +02:00 |
|
Enno Rehling
|
c76b118fb8
|
eliminate game/order from XML data
|
2015-09-12 17:12:02 +02:00 |
|
Enno Rehling
|
44eb3a4f58
|
disable keywords through JSON configuration
|
2015-09-12 17:06:55 +02:00 |
|
Enno Rehling
|
7906cdbcb6
|
do not read gamename from XML, read it from JSON only (two mechanisms for the same feature are too many)
|
2015-09-12 16:49:18 +02:00 |
|
Enno Rehling
|
d65e9aaf94
|
eliminate xml reading of produceexp chance
|
2015-09-12 16:42:02 +02:00 |
|
Enno Rehling
|
8a95ea0c00
|
speeding up produceexp_chance
|
2015-09-12 16:41:22 +02:00 |
|
Enno Rehling
|
9bdc811582
|
produceexp uses a json-configurable constant
make get_param_flt return a double, floats are for wimps.
|
2015-09-12 16:38:51 +02:00 |
|
Enno Rehling
|
68c448b3fb
|
fix signature of callback
|
2015-09-12 16:29:57 +02:00 |
|
Enno Rehling
|
d1686849e0
|
refactoring: move produceexp into unit module, for want of a better one. add a bit of test coverage.
https://bugs.eressea.de/view.php?id=2137 - fix learning-by-doing with less than u->number people.
|
2015-09-12 16:25:47 +02:00 |
|
Enno Rehling
|
aa32cf190e
|
remove xmlreader code for prefixes
|
2015-09-12 13:40:10 +02:00 |
|
Enno Rehling
|
09efd9c2a9
|
fix anything that uses the calendar module. opps.
|
2015-09-12 12:54:49 +02:00 |
|
Enno Rehling
|
13e1573611
|
moving the calendar module out of the kernel directory, it does not belong with the major game objects
|
2015-09-12 12:54:09 +02:00 |
|
Enno Rehling
|
47c95aee35
|
implement JSON prefixes. fix free_prefixes not resetting size (TODO: quicklist).
|
2015-09-12 12:49:12 +02:00 |
|
Enno Rehling
|
f0e255924f
|
add a unit test for add/free prefixes. fix bad free_prefixes call site.
|
2015-09-12 12:41:04 +02:00 |
|
Enno Rehling
|
9f6b374056
|
add a (red) test for JSON prefixes.
|
2015-09-12 12:33:25 +02:00 |
|
Enno Rehling
|
44d982d210
|
free race prefixes when the game is done (small memory leak).
|
2015-09-12 12:29:42 +02:00 |
|
Enno Rehling
|
f1476c2167
|
refactoring: split out a module for race prefixes
|
2015-09-12 12:24:10 +02:00 |
|
Enno Rehling
|
bd51ac7dd7
|
eliminate terrain parsing from xmlreader.c, it's all in JSON now!
|
2015-09-11 22:46:47 +02:00 |
|
Enno Rehling
|
c57918ede0
|
replace XML terrains for E3 and E4 with JSON configuration
|
2015-09-11 22:43:08 +02:00 |
|
Enno Rehling
|
b4971dd651
|
replace all of the E2 terrains with JSON data (no more XML!)
|
2015-09-11 22:11:59 +02:00 |
|
Enno Rehling
|
7c4d18ec2d
|
avoid an annoying division by zero when terrains are not fully initialized (size=0)
|
2015-09-11 21:31:59 +02:00 |
|
Enno Rehling
|
db4cb2618b
|
transfer most core and all game-specific terrains for E2 from XML to JSON.
|
2015-09-11 21:14:10 +02:00 |
|
Enno Rehling
|
9df5799efd
|
define core plain and ocean in JSON for E2.
|
2015-09-11 12:52:18 +02:00 |
|
Enno Rehling
|
a582c69523
|
finished and tested: terrains can be completely defined in JSON.
|
2015-09-11 12:27:45 +02:00 |
|
Enno Rehling
|
43bac506a4
|
fix bad size for calloc.
|
2015-09-11 12:25:28 +02:00 |
|