Enno Rehling
0410581907
Merge branch 'market_tests' of https://github.com/stm2/server into stm2-market_tests
...
Conflicts:
src/move.test.c
src/study.c
2015-11-26 18:42:23 +01:00
Steffen Mecke
fe49f01bb6
added moa tests for buildingtype_exists
2015-11-25 23:25:59 +01:00
Enno Rehling
c85e489f4f
Merge branch 'monster_leftovers' of https://github.com/stm2/server into stm2-monster_leftovers
...
Conflicts:
src/kernel/unit.c
src/laws.test.c
src/monsters.c
2015-11-25 14:25:42 +01:00
Enno Rehling
f559c263e3
cleanup of config.c: move more code to other modules like unit.c and faction.c
2015-11-24 19:53:27 +01:00
Enno Rehling
8aa7fec54c
config.c cleanup: move attribute registration to attributes.c
2015-11-24 19:32:52 +01:00
Enno Rehling
84a943b698
fix gcc build
2015-11-24 19:15:53 +01:00
Enno Rehling
64b84481b2
refactoring: move parsing and allies code out of config.c
2015-11-24 18:52:09 +01:00
Enno Rehling
817d81dbf9
remove the rules.hunger.reduces_skill variable, no game was doing anything other than the default.
2015-11-23 21:05:25 +01:00
Enno Rehling
0a47f0e398
eliminate SkillCap feature, it was stupid and not used by any game, ever
2015-11-23 20:58:51 +01:00
Enno Rehling
5b9333f6d9
Merge branch 'release-3.7' into develop
...
Conflicts:
src/buildno.h
src/monsters.c
2015-11-23 17:12:48 +01:00
Enno Rehling
48c75466b6
kill static caches for floating-point variables
2015-11-22 17:32:35 +01:00
Enno Rehling
2e392b4d7c
eliminate even more static variable caches
2015-11-22 16:14:27 +01:00
Enno Rehling
f7698d92a9
change how migrant quota is configured for a race, eliminate the related rule caching
2015-11-22 15:53:50 +01:00
Enno Rehling
5f457f77b4
refactoring: move those count_* functions out of config.c
2015-11-22 15:46:14 +01:00
Enno Rehling
17068af332
unusual potion delay attribute can use a potion in another region? unclear what this code does, but fixing my bad assumption.
2015-11-22 14:36:05 +01:00
Enno Rehling
35e7a0bc79
eliminate global.cookie and the cache-invalidation which it enabled
2015-11-22 12:50:10 +01:00
Enno Rehling
73fc5a51b3
remove more junk defines from config.h, move them closer to where they belong
2015-11-22 12:47:57 +01:00
Enno Rehling
bf74eb1446
cleanup: remove movement constatns from config.h
2015-11-22 12:41:22 +01:00
Enno Rehling
cf6084a5ca
refactoring: move game configuration defines out of config.h
...
temporarily pushing them into settings.h where others already are, though they should be in their own modules or in config files.
2015-11-22 12:37:25 +01:00
Enno Rehling
74b1f9872e
change visibility of configuration data structures, local to config.c only
2015-11-22 12:27:08 +01:00
Enno Rehling
fe173e9551
refactor: make sure global.paramteres is used only inside config.c
2015-11-22 12:24:27 +01:00
Enno Rehling
edcd79d044
add a config_token function to look for a token inside a list
2015-11-22 12:20:33 +01:00
Enno Rehling
a4cb5e2906
replace all get_param_* for global.parameters with config_get_*
2015-11-22 10:44:46 +01:00
Enno Rehling
b05fe9316a
introducing config_set and config_get so we don't have to refer to globals.parameters everywhere
2015-11-22 10:33:31 +01:00
Enno Rehling
66dd1b8172
remove produce_exp caching in static variables (more slowdown)
2015-11-22 10:21:37 +01:00
Enno Rehling
f0a47321d6
reduce log spam
2015-11-21 21:49:33 +01:00
Enno Rehling
990fda6234
clean up config.c, remove static configuration caching
2015-11-21 18:13:16 +01:00
Enno Rehling
bc936bf019
eliminate more static variable configuration caching
2015-11-21 13:52:47 +01:00
Enno Rehling
7e27928d17
eliminate static variables and cache logic from more modules
2015-11-21 12:28:20 +01:00
Enno Rehling
06f8ba9ee4
faster lookup for get_param with tries
...
eliminate unnecessary constatn from rand.c
2015-11-20 15:48:17 +01:00
Steffen Mecke
a6757ecf9d
Merge branch 'develop' into massive_overload
...
Conflicts:
src/move.test.c
2015-11-19 14:54:14 +01:00
Steffen Mecke
a7a82662b7
reduce maximum overload damage to 38%
2015-11-17 15:47:43 +01:00
Steffen Mecke
742a30cc39
fix seaserpents
...
seaserpents could not do piracy
seaserpents should be able to attack after move
2015-11-17 12:17:28 +01:00
Steffen Mecke
8cec4b20e0
reduce code obfuscation
2015-11-17 02:14:08 +01:00
Steffen Mecke
1789bc06e9
monster faction may learn from experience
2015-11-17 02:13:57 +01:00
Enno Rehling
6237e6dfe2
Merge branch 'release-3.7' into develop
2015-11-16 14:30:31 +01:00
Steffen Mecke
5326bbd9e4
refactored inside_building/building_is_active/active_building
2015-11-16 02:13:48 +01:00
Steffen Mecke
3a18384ddb
overfull ships do not drift but take damage
...
http://bugs.eressea.de/view.php?id=2157
removed exploit:
ships more than 2 times over their ship type's capacity do not drift but take 30% to 100% damage
2015-11-15 12:43:05 +01:00
Steffen Mecke
4ab92e3caf
fixed descriptions of spells with parameters (bug #2060+1867)
2015-11-13 00:57:14 +01:00
Steffen Mecke
f3972a2390
prepared test for nr_spell
2015-11-13 00:57:14 +01:00
Steffen Mecke
251126054e
add missing NULL check to in_safe_building
2015-11-13 00:50:54 +01:00
Enno Rehling
5ef9b624ff
Merge branch 'release-3.7' into develop
2015-11-12 18:11:21 +01:00
Enno Rehling
7fb5adc7af
in_safe_building needs a test and some changes to logic
...
github issue #393 fixed
2015-11-12 17:55:39 +01:00
Steffen Mecke
e2b56cd04a
fix morale change when region owner changes
...
http://bugs.eressea.de/view.php?id=2139
2015-11-12 16:09:26 +01:00
Enno Rehling
972b8cee40
CID 22436 Ignoring number of bytes read
...
github issue #333
2015-11-11 15:55:39 +01:00
Enno Rehling
f69311b141
Merge branch 'develop' of github.com:eressea/server into develop
2015-11-11 15:15:30 +01:00
Enno Rehling
4eb4ff40ac
https://bugs.eressea.de/view.php?id=2155
...
monsters do not attack units inside a castle or watch
dragons do not attack guards
2015-11-11 14:36:56 +01:00
Enno Rehling
e14cc50252
CID 22522, 22520 Resource leak
...
helping coverity scan to understand this code
2015-11-09 20:05:55 +01:00
Enno Rehling
ea8721367a
test and fix shock trigger.
...
https://bugs.eressea.de/view.php?id=2154
2015-11-09 19:43:51 +01:00
Enno Rehling
28781dfcc8
Merge pull request #378 from ennorehling/develop
...
spells are allowed to have 0 hp
2015-11-09 16:45:08 +01:00
Enno Rehling
4790950daf
spells are allowed to have 0 hp
...
https://bugs.eressea.de/view.php?id=2150
2015-11-09 16:39:30 +01:00
Enno Rehling
e9ed30f9db
Merge pull request #377 from ennorehling/develop
...
Bug 2152: Parteitarnung
2015-11-09 16:30:57 +01:00
Enno Rehling
6d0bcb246d
fix compilation and setting parameters to null
2015-11-09 13:55:09 +01:00
Enno Rehling
ee02721c21
fix and tests for otherfaction attributes in E2
...
https://bugs.eressea.de/view.php?id=2152
2015-11-09 13:36:52 +01:00
Enno Rehling
bf8cc4cb08
trying to trace down an intermittently failing test on windows
2015-11-08 10:34:43 +01:00
Enno Rehling
318820fb00
eliminate use of test_create_world
2015-11-07 23:49:45 +01:00
Enno Rehling
43ab9e3304
Merge pull request #372 from TurnerSE/bug/#1859
...
Scheint ja zu funktionieren? Wenn etwas anderes kaputt geht, dann hat das nicht genug Tests, das ist auch eine Lehre. Und noch ist ja Zeit zum Release, um das zu merken.
2015-11-07 19:21:16 +01:00
Enno Rehling
26b6ae4e30
github issue #374
...
stick some assertions in natural_armor
refactor it for readability
eliminate a static memory leak
reset num_races to zero at end of test
2015-11-07 18:21:47 +01:00
Enno Rehling
2f8dc29396
clean up item tests so they don't use test_create_world
...
fix intermittent skillpotion test
2015-11-07 13:52:18 +01:00
Philipp Dreher
663d947b2a
New behaviour in case of low skill during building
...
Insufficient skill after hitting the next improvement stage is now
handled by leaving the for-loop and skipping to after-build-processing.
2015-11-06 21:04:35 +01:00
Philipp Dreher
b0a986e155
Revert "added a lua-test"
...
This reverts commit a452ad1517
.
2015-11-06 20:57:19 +01:00
Philipp Dreher
a452ad1517
added a lua-test
...
New lua-test for the bug concerning the minskill for castle-stages.
(#1859 )
2015-11-06 20:53:10 +01:00
Philipp Dreher
be5d81acd1
Revert "new test"
...
This reverts commit cb16315e7c
.
2015-11-06 20:51:38 +01:00
Philipp Dreher
cb16315e7c
new test
...
Added test for the handling of castles' buildstages and their individual
skillcaps.
2015-11-06 13:14:19 +01:00
Enno Rehling
8a057f183f
CID 22580 Time of check time of use
...
no need to check this first
2015-11-05 13:22:51 +01:00
Enno Rehling
797eee025d
fix cb_insert comparison (new return value for success)
2015-11-05 13:01:48 +01:00
Enno Rehling
2a7fc87656
CID 30742 Dereference before null check
...
CID 30741 ditto
2015-11-05 10:59:14 +01:00
Enno Rehling
b81e56d306
CID 22486 Dereference after null check
2015-11-05 08:32:21 +01:00
Enno Rehling
b6190b5193
CID 22527 Resource leak
2015-11-04 19:20:34 +01:00
Enno Rehling
8ab4784e3f
Merge branch 'coverity-scan' of https://github.com/ennorehling/eressea into ennorehling-coverity-scan
...
Conflicts:
src/kernel/jsonconf.c
src/kernel/save.h
src/names.c
2015-11-04 12:44:45 +01:00
Enno Rehling
8bc44d82ed
CID 22500 Argument cannot be negative
2015-11-04 12:29:51 +01:00
Enno Rehling
5887e8e48f
CID 22434 Ignoring number of bytes read
2015-11-04 12:19:16 +01:00
Enno Rehling
47f678d2a3
CID 22436 Ignoring number of bytes read, github issue #333
2015-11-04 11:51:19 +01:00
Enno Rehling
731dac3363
CID 22437 Unchecked return value from library
...
github issue #332
2015-11-04 11:45:13 +01:00
Enno Rehling
d4ff807c20
Merge pull request #364 from ennorehling/coverity-fixes
...
several smaller coverity fixes
2015-11-04 11:04:32 +01:00
Enno Rehling
024e4c45ca
fix a bug introduced by f78fe842
(CID 22443)
2015-11-04 10:40:53 +01:00
Enno Rehling
c57668e6ee
failing test for newly discovered storage problems
2015-11-04 09:48:51 +01:00
Enno Rehling
04b5bc0c60
CID 22474 Evaluation order violation
2015-11-03 23:19:35 +01:00
Enno Rehling
1093a23d5a
CID 22464 Division or modulo by zero
2015-11-03 23:14:06 +01:00
Enno Rehling
876e4122b1
CID 22463 Division or modulo by zero
2015-11-03 23:13:04 +01:00
Enno Rehling
307c5ec85b
CID 22435 Unchecked return value from library
2015-11-03 22:56:05 +01:00
Enno Rehling
0c5ef21c10
CID 22434 Ignoring number of bytes read
...
also potential missing null-termination
2015-11-03 22:53:19 +01:00
Enno Rehling
f959f43f1e
extensive tests for armor calculation
2015-11-03 18:59:09 +01:00
Enno Rehling
91a6324a97
cleanup: functions do not need to be dereferenced with an & in C.
2015-11-03 13:30:34 +01:00
Enno Rehling
7e81b98fa4
Merge pull request #339 from TurnerSE/improvement/CID22481
...
Improvement/cid22481
2015-11-03 13:08:03 +01:00
Philipp Dreher
07fd3dc970
formal correction
2015-11-02 18:06:19 +01:00
Enno Rehling
072bfd3912
testin building_is_active
...
testing multiple units in one building
2015-11-02 15:06:30 +01:00
Enno Rehling
4bf2509fb3
test inside_building vs. overflow
...
fix default building capacity (should be 1 per size)
2015-11-02 14:56:58 +01:00
Enno Rehling
42ae086def
unit is inisde a building also when it was not paid for
2015-11-02 14:49:48 +01:00
Enno Rehling
24ff4c301d
refactor: separate building_is_active from inside_building
2015-11-02 14:18:50 +01:00
Philipp Dreher
b107ddadf5
added assert to check the faction-pointer
2015-11-01 21:43:18 +01:00
Philipp Dreher
491e5faed9
Revert "general check for sf->faction's validity"
...
This reverts commit f18b5ea7d2
.
2015-11-01 21:40:06 +01:00
Philipp Dreher
f18b5ea7d2
general check for sf->faction's validity
...
The handling of an ally without a valid faction-pointer is now skipped
in favor of a logged error.
2015-11-01 18:54:29 +01:00
Enno Rehling
21a2313e2a
CID 22517: Parse warning (PW.PARAM_SET_BUT_NOT_USED)
2015-10-30 15:20:06 +01:00
Enno Rehling
e7ca5345d7
CID 22509: Dereference null return value (NULL_RETURNS)
...
potential problems at the edge of the map.
2015-10-30 12:57:07 +01:00
Enno Rehling
e1eb5098d4
CID 22554: Improper use of negative value (REVERSE_NEGATIVE)
...
I believe this was a false positive, but more asserts can never hurt.
2015-10-30 12:40:48 +01:00
Enno Rehling
93b7bacff5
CID 22552: Dereference before null check (REVERSE_INULL)
2015-10-30 12:37:27 +01:00
Enno Rehling
5d273e475e
CID 22558: Copy into fixed size buffer (STRING_OVERFLOW)
...
bsdstring buffer size check
2015-10-30 11:41:59 +01:00
Enno Rehling
1fb04179dc
CID 22557: Copy into fixed size buffer (STRING_OVERFLOW)
...
eliminate code duplication. bsdstring is better than libc strings.
2015-10-30 11:39:47 +01:00
Enno Rehling
4eb6a89821
CID 26262: short and unsigned types are the devil, use int everywhere for fewer headaches
2015-10-29 20:39:44 +01:00