Enno Rehling
fce3f63cc1
CID 22529 Resource leak
...
github issue #351
allocation call optimization for small units
2015-11-05 11:22:16 +01:00
Enno Rehling
530f729621
CID 22499 Missing break in switch
...
github issue #357
nice catch!
2015-11-05 11:18:39 +01:00
Enno Rehling
4c861aa40d
CID 22496 Infinite loop
...
github issue #356
this is only relevant to old data files, it appears.
2015-11-05 11:17:31 +01:00
Enno Rehling
58c1d83c9e
CID 22491 FORWARD_NULL
...
github issue #352
fals positive, rewriting code to appease coverity
2015-11-05 11:14:53 +01:00
Enno Rehling
62d7e9e944
CID 22473 Evaluation order violation
...
github issue #347
2015-11-05 11:11:02 +01:00
Enno Rehling
e16e669294
CID LAST_ROW 22455 Logically dead code
...
github issue #359
song of confusion was not selecting from fleeing units
2015-11-05 11:08:55 +01:00
Enno Rehling
2a7fc87656
CID 30742 Dereference before null check
...
CID 30741 ditto
2015-11-05 10:59:14 +01:00
Enno Rehling
0206ffbec6
accidentally inverted condition when fixing volcano attribute
2015-11-05 09:57:57 +01:00
Enno Rehling
c0af920d0d
Merge pull request #367 from ennorehling/coverity-scan
...
Coverity scan fixes, part n+1
2015-11-05 09:30:55 +01:00
Enno Rehling
92d1596109
CID 22444: unchecked return value from fseek
2015-11-05 09:18:57 +01:00
Enno Rehling
a8daf061de
missing include
2015-11-05 09:14:02 +01:00
Enno Rehling
91758d2e51
CID 22439 Unchecked return value from library
2015-11-05 09:00:52 +01:00
Enno Rehling
52edf15cec
CID 22438 Unchecked return value from library
2015-11-05 08:57:56 +01:00
Enno Rehling
64e8d4b094
CID 22484 Explicit null dereferenced
2015-11-05 08:50:01 +01:00
Enno Rehling
744246ab34
CID 22498 Missing break in switch
2015-11-05 08:48:03 +01:00
Enno Rehling
06513d0db4
coverity CID 22578
2015-11-05 08:46:19 +01:00
Enno Rehling
ba69f72116
CID 22502 Argument cannot be negative
...
these curses macros are hard to decipher, I think this may be a kind of false positive because stdscr is always not-null?
2015-11-05 08:40:09 +01:00
Enno Rehling
f83e71e99a
22483 Dereference after null check
2015-11-05 08:36:32 +01:00
Enno Rehling
c68829029b
22485 Dereference after null check
2015-11-05 08:35:03 +01:00
Enno Rehling
b81e56d306
CID 22486 Dereference after null check
2015-11-05 08:32:21 +01:00
Philipp Dreher
d5f8448d7d
changed the handling of an item the unit has no access to
...
Since the return of display_item() implies that the item, which is
definitely an item but not a potion at this point, is neither in the
inventory of the unit nor an item in the region or the faction's item
pool, the existing message 36 is now triggered in this case and the
previously conditional break is now done indepent of the outcome of
display_item, which shouldn't be critical (it's an item so it can't be
a spell or a race).
2015-11-04 23:48:30 +01:00
Enno Rehling
b6190b5193
CID 22527 Resource leak
2015-11-04 19:20:34 +01:00
Enno Rehling
4d1f2327fe
CID 22545: Leak of memory or pointers to system resources
...
github issue #335
volcano destruction was not causing a resuction in wages etc., because we forgot to add the attribute to the region.
2015-11-04 19:13:15 +01:00
Enno Rehling
c9f886078b
CID 22452 'Constant' variable guards dead code
...
github issue #353 there is no a_fshidden attribute.
2015-11-04 19:08:45 +01:00
Enno Rehling
a6039c7611
Merge pull request #366 from ennorehling/coverity-scans
...
Fix more coverity scan issues
2015-11-04 15:40:12 +01:00
Enno Rehling
075de3c919
math is hard, typing is harder. bugfix. thank you, valgrind my friend.
2015-11-04 15:00:15 +01:00
Enno Rehling
67e2eafbcf
add missing include (MSVC is not picky enough)
2015-11-04 14:55:13 +01:00
Enno Rehling
10f2dd2d6e
CID 22497 Missing break in switch
...
make this code easier to read, favor if over switch
2015-11-04 14:52:10 +01:00
Enno Rehling
65f1574312
CID 22490 Dereference after null check
2015-11-04 14:27:38 +01:00
Enno Rehling
0271336428
CID 22494 Identical code for different branches
2015-11-04 14:24:44 +01:00
Enno Rehling
6e31751731
CID 22542 Resource leak
...
Fix broken error mesasge: "Die Einheit hat diesen Gegenstand zwar, aber sämtliche $int($reservation) $resource($resource,$reservation) sind reserviert."
2015-11-04 14:22:45 +01:00
Enno Rehling
0a5bd9d356
22480 Dereference after null check
2015-11-04 14:19:43 +01:00
Enno Rehling
eea0186601
22440 Unchecked return value from library
...
rewrite log rotation, check errors
2015-11-04 14:16:15 +01:00
Enno Rehling
30cc5405ae
CID 22467: Division or modulo by zero
...
github issue #348
2015-11-04 12:59:03 +01:00
Enno Rehling
05ff554053
Merge branch 'ennorehling-coverity-scan' into develop
2015-11-04 12:44:56 +01:00
Enno Rehling
8ab4784e3f
Merge branch 'coverity-scan' of https://github.com/ennorehling/eressea into ennorehling-coverity-scan
...
Conflicts:
src/kernel/jsonconf.c
src/kernel/save.h
src/names.c
2015-11-04 12:44:45 +01:00
Enno Rehling
45b6de9c0d
CID 22468 Division or modulo by zero
2015-11-04 12:30:46 +01:00
Enno Rehling
8bc44d82ed
CID 22500 Argument cannot be negative
2015-11-04 12:29:51 +01:00
Enno Rehling
5887e8e48f
CID 22434 Ignoring number of bytes read
2015-11-04 12:19:16 +01:00
Enno Rehling
b7b1ae43c2
CID 22493 Dereference after null check
...
CID 22458 Logically dead code
github issue #361
2015-11-04 12:16:52 +01:00
Enno Rehling
1a715d6736
CID 22493 Dereference after null check
2015-11-04 12:14:12 +01:00
Enno Rehling
657f5044e5
CID 22495 Identical code for different branches
2015-11-04 12:11:26 +01:00
Enno Rehling
9d4489972b
CID 22447 Calling risky function
...
github issue #336
2015-11-04 12:09:45 +01:00
Enno Rehling
c090f8e1f4
CID 22441 Unchecked return value from library
2015-11-04 12:03:26 +01:00
Enno Rehling
d6cd1feb48
CID 22456: 'Constant' variable guards dead code
...
github issue #360
prayers sind ein feature, das nie fertig entwickelt wurde
2015-11-04 11:59:17 +01:00
Enno Rehling
978dd1400f
CID 22465 Division or modulo by zero
2015-11-04 11:57:13 +01:00
Enno Rehling
a02b5f343e
CID 22488 Dereference after null check
2015-11-04 11:55:04 +01:00
Enno Rehling
2d7aedea5e
Merge branch 'coverity-scan' of https://github.com/ennorehling/eressea.git
2015-11-04 11:51:48 +01:00
Enno Rehling
47f678d2a3
CID 22436 Ignoring number of bytes read, github issue #333
2015-11-04 11:51:19 +01:00
Enno Rehling
3fe7b94cc7
CID 22436 Ignoring number of bytes read
2015-11-04 11:47:49 +01:00