http://bugs.eressea.de/view.php?id=1784

espionage should show the faction of the spied unit in the report.

src/gamecode/spy.c

@@ -73,6 +73,7 @@ spy_message(int spy, const unit *u, const unit *target)
     if (fv && fv!=target->faction) {
       /* wahre Partei */
       ADDMSG(&u->faction->msgs, msg_message("spyreport_faction", "target faction", target, target->faction));
+      flist_add(&u->faction->seen_factions, target->faction);
     }
   }
   if (spy > 0) {

src/kernel/faction.c

@@ -505,3 +505,19 @@ f_get_alliance(const struct faction * f)
   }
   return NULL;
 }
+
+void
+flist_add(faction_list ** flist, faction * sf)
+{
+  faction_list ** fnew = flist;
+  while (*fnew && (*fnew)->data->no < sf->no) {
+    fnew =&(*fnew)->next;
+  }
+  if ((*fnew==NULL) || (*fnew)->data!=sf) {
+    faction_list * finsert = malloc(sizeof(faction_list));
+    finsert->next = *fnew;
+    *fnew = finsert;
+    finsert->data = sf;
+  }
+}
+

src/kernel/faction.h

@@ -108,6 +108,7 @@ typedef struct faction {
   } * battles;
   struct item * items; /* items this faction can claim */
   struct seen_region ** seen;
+  struct faction_list * seen_factions;
 } faction;
 
 extern struct faction *factions;
@@ -117,6 +118,7 @@ typedef struct faction_list {
 	struct faction * data;
 } faction_list;
 
+void flist_add(struct faction_list ** flist, struct faction * sf);
 extern const struct unit * random_unit_in_faction(const struct faction *f);
 extern const char * factionname(const struct faction * f);
 extern struct unit * addplayer(struct region *r, faction * f);

src/kernel/reports.c

@@ -883,21 +883,6 @@ ucansee(const struct faction *f, const struct unit *u, const struct unit *x)
   return x;
 }
 
-static void
-add_faction(faction_list ** flist, faction * sf)
-{
-  faction_list ** fnew = flist;
-  while (*fnew && (*fnew)->data->no < sf->no) {
-    fnew =&(*fnew)->next;
-  }
-  if ((*fnew==NULL) || (*fnew)->data!=sf) {
-    faction_list * finsert = malloc(sizeof(faction_list));
-    finsert->next = *fnew;
-    *fnew = finsert;
-    finsert->data = sf;
-  }
-}
-
 int
 stealth_modifier(int seen_mode)
 {
@@ -921,14 +906,15 @@ get_addresses(report_context * ctx)
   seen_region * sr = NULL;
   region *r;
   const faction * lastf = NULL;
-  faction_list * flist = calloc(1, sizeof(faction_list));
+  faction_list * flist = ctx->f->seen_factions;
 
-  flist->data = ctx->f;
+  ctx->f->seen_factions = NULL; /* do not delete it twice */
+  flist_add(&flist, ctx->f);
 
   if (f_get_alliance(ctx->f)) {
     faction_list * member = ctx->f->alliance->members;
     for (;member;member=member->next) {
-      add_faction(&flist, member->data);
+      flist_add(&flist, member->data);
     }
   }
 
@@ -945,7 +931,7 @@ get_addresses(report_context * ctx)
         faction * sf = visible_faction(ctx->f, u);
         if (lastf!=sf) {
           if (u->building || u->ship || (stealthmod>INT_MIN && cansee(ctx->f, r, u, stealthmod))) {
-            add_faction(&flist, sf);
+            flist_add(&flist, sf);
             lastf = sf;
           }
         }
@@ -961,7 +947,7 @@ get_addresses(report_context * ctx)
             unit * u2 = (unit*)a->data.v;
             if (u2->faction==ctx->f) {
               if (cansee_unit(u2, u, stealthmod)) {
-                add_faction(&flist, sf);
+                flist_add(&flist, sf);
                 lastf = sf;
                 break;
               }
@@ -979,7 +965,7 @@ get_addresses(report_context * ctx)
           boolean ballied = sf && sf!=ctx->f && sf!=lastf
             && !fval(u, UFL_ANON_FACTION) && cansee(ctx->f, r, u, stealthmod);
           if (ballied || ALLIED(ctx->f, sf)) {
-            add_faction(&flist, sf);
+            flist_add(&flist, sf);
             lastf = sf;
           }
         }
@@ -992,7 +978,7 @@ get_addresses(report_context * ctx)
     faction *f2;
     for (f2 = factions; f2; f2 = f2->next) {
       if (f2->alliance == ctx->f->alliance) {
-        add_faction(&flist, f2);
+        flist_add(&flist, f2);
       }
     }
   }