fix MSVC warning levels, move _CRT_SECURE_NO_WARNINGS define to sources

CMakeLists.txt

@@ -1,4 +1,5 @@
-cmake_minimum_required(VERSION 2.9)
+cmake_minimum_required(VERSION 3.13)
+
 if (WIN32)
 file(TO_CMAKE_PATH "${CMAKE_MODULE_PATH}" CMAKE_MODULE_PATH )
 file(TO_CMAKE_PATH "${CMAKE_PREFIX_PATH}" CMAKE_PREFIX_PATH )
@@ -17,7 +18,6 @@ set (HAVE_STRLCAT 0)
 set (HAVE_LIBBSD 0)
 set (HAVE_SIGNAL_H 0)
 set (HAVE_EXECINFO_H 0)
-include (MSVC)
 else (MSVC)
 
 include (CheckIncludeFile)
@@ -41,6 +41,7 @@ if (NOT CURSES_FOUND)
 find_package (Curses)
 endif (NOT CURSES_FOUND)
 
+#find_package (BerkeleyDB REQUIRED)
 find_package (SQLite3 REQUIRED)
 find_package (IniParser REQUIRED)
 find_package (CJSON REQUIRED)

clibs

@@ -1 +1 @@
-Subproject commit 6cdcdd62d167e0159d10d4e95b5def97d785fdef
+Subproject commit 8c3ce73e861c952d04a28949b4a80e68c2cce8fd

cmake/Modules/MSVC.cmake

@@ -1,19 +0,0 @@
-MACRO (MSVC_CRT_SECURE_NO_WARNINGS)
-    IF (MSVC)
-        FOREACH (target ${ARGN})
-            SET_TARGET_PROPERTIES (${target} PROPERTIES
-                COMPILE_DEFINITIONS _CRT_SECURE_NO_WARNINGS
-            )
-        ENDFOREACH (target)
-    ENDIF (MSVC)
-ENDMACRO (MSVC_CRT_SECURE_NO_WARNINGS)
-
-MACRO (MSVC_SET_WARNING_LEVEL level)
-    IF (MSVC)
-    IF(CMAKE_C_FLAGS MATCHES "/W[0-4]")
-        STRING(REGEX REPLACE "/W[0-4]" "/W${level}" CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")
-    ELSE()
-        SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /W${level}")
-    ENDIF()
-    ENDIF(MSVC)
-ENDMACRO (MSVC_SET_WARNING_LEVEL)

src/CMakeLists.txt

@@ -1,3 +1,5 @@
+cmake_minimum_required(VERSION 3.15)
+cmake_policy(SET CMP0092 NEW)
 project (server C)
 
 include_directories (${CMAKE_CURRENT_SOURCE_DIR})
@@ -19,14 +21,13 @@ COMPILE_DEFINITIONS ERESSEA_BUILDNO="${ERESSEA_BUILDNO}")
 ENDIF()
 
 IF (CMAKE_COMPILER_IS_GNUCC)
-    SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wvla")
+  add_compile_options(-Wvla)
 ENDIF()
 IF (CMAKE_COMPILER_IS_GNUCC OR CMAKE_C_COMPILER_ID MATCHES "Clang")
-#    SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wconversion -Wno-sign-conversion")
-SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wsign-compare -Wall -Werror -Wno-unknown-pragmas -Wstrict-prototypes -Wpointer-arith -Wno-char-subscripts -Wno-long-long")
-#    SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=c89")
+  add_compile_options(-Wsign-compare -Wall -Werror -Wno-unknown-pragmas -Wstrict-prototypes -Wpointer-arith -Wno-char-subscripts -Wno-long-long)
 ELSEIF(MSVC)
-    SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /W4 /WX /MP /D_CRT_SECURE_NO_WARNINGS /D_USE_MATH_DEFINES")
+  add_compile_options(/WX /MP)
+#  set(EXTRA_C_FLAGS /WX /MP /D_CRT_SECURE_NO_WARNINGS /D_USE_MATH_DEFINES)
     set(CMAKE_EXE_LINKER_FLAGS_DEBUG
         "${CMAKE_EXE_LINKER_FLAGS_DEBUG} /NODEFAULTLIB:libc.lib /NODEFAULTLIB:libcmt.lib /NODEFAULTLIB:libcd.lib /NODEFAULTLIB:libcmtd.lib /NODEFAULTLIB:msvcrt.lib")
     set(CMAKE_EXE_LINKER_FLAGS_RELEASE
@@ -46,6 +47,8 @@ ELSEIF(CMAKE_COMPILER_IS_GCC)
     ENDIF()
 ENDIF(CMAKE_COMPILER_IS_CLANG)
 
+string(REGEX REPLACE "/W[3|4]" "/w" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
+
 add_subdirectory(util)
 add_subdirectory(kernel)
 add_subdirectory(items)
@@ -311,24 +314,24 @@ if (SQLite3_FOUND)
 target_include_directories (game PRIVATE ${SQLite3_INCLUDE_DIRS})
 target_link_libraries(eressea ${SQLite3_LIBRARIES})
 target_link_libraries(test_eressea ${SQLite3_LIBRARIES})
-add_compile_definitions(game PRIVATE USE_SQLITE)
+target_compile_definitions(game PRIVATE USE_SQLITE)
 elseif (DB_FOUND)
 #include_directories (${DB_INCLUDE_DIR})
 target_link_libraries(eressea ${DB_LIBRARIES})
 target_link_libraries(test_eressea ${DB_LIBRARIES})
-add_compile_definitions(game PRIVATE USE_DB)
+target_compile_definitions(game PRIVATE USE_DB)
 endif(SQLite3_FOUND)
 
 if (READLINE_FOUND)
 #include_directories (${READLINE_INCLUDE_DIR})
 target_link_libraries(eressea ${READLINE_LIBRARY})
-add_compile_definitions(eressea PRIVATE DUSE_READLINE)
+target_compile_definitions(eressea PRIVATE DUSE_READLINE)
 endif (READLINE_FOUND)
 
 if (CURSES_FOUND)
 target_include_directories (eressea PRIVATE ${CURSES_INCLUDE_DIRS})
 target_link_libraries(eressea ${CURSES_LIBRARIES})
-add_compile_definitions(eressea PRIVATE USE_CURSES)
+target_compile_definitions(eressea PRIVATE USE_CURSES)
 endif(CURSES_FOUND)
 
 if (EXPAT_FOUND)

src/attributes/attributes.c

@@ -145,7 +145,7 @@ static int read_ext(variant *var, void *owner, gamedata *data)
 
     UNUSED_ARG(var);
     READ_INT(data->store, &len);
-    data->store->api->r_bin(data->store->handle, NULL, (size_t)len);
+    data->store->api->r_str(data->store->handle, NULL, (size_t)len);
     return AT_READ_OK;
 }
 

src/attributes/key.c

@@ -1,4 +1,6 @@
-#include <platform.h>
+#ifdef _MSC_VER
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #include <kernel/config.h>
 #include "key.h"
 

src/battle.c

@@ -1,4 +1,5 @@
 #ifdef _MSC_VER
+#define _CRT_SECURE_NO_WARNINGS
 #include <platform.h>
 #endif
 

src/battle.test.c

@@ -1,4 +1,8 @@
-#include <platform.h>
+#ifdef _MSC_VER
+#ifndef _CRT_SECURE_NO_WARNINGS
+#define _CRT_SECURE_NO_WARNINGS
+#endif
+#endif
 
 #include "battle.h"
 

src/bind_config.c

@@ -1,7 +1,8 @@
 #ifdef _MSC_VER
-#include <platform.h>
+#ifndef _CRT_SECURE_NO_WARNINGS
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #endif
-
 #include "bind_config.h"
 
 #include "jsonconf.h"

src/bind_eressea.c

@@ -1,5 +1,7 @@
 #ifdef _MSC_VER
-#include <platform.h>
+#ifndef _CRT_SECURE_NO_WARNINGS
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #endif
 #include "bind_eressea.h"
 

src/bind_storage.c

@@ -1,7 +1,8 @@
 #ifdef _MSC_VER
-#include <platform.h>
+#ifndef _CRT_SECURE_NO_WARNINGS
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #endif
-
 #include "bind_storage.h"
 
 #include <kernel/save.h>

src/bindings.c

@@ -1,7 +1,8 @@
 #ifdef _MSC_VER
-#include <platform.h>
+#ifndef _CRT_SECURE_NO_WARNINGS
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #endif
-
 #include "bindings.h"
 #include "bind_tolua.h"
 

src/checker.c

@@ -1,7 +1,6 @@
-#ifdef _MSV_VER
-#include <platform.h>
+#ifdef _MSC_VER
+#define _CRT_SECURE_NO_WARNINGS
 #endif
-
 #include "util/order_parser.h"
 #include "util/keyword.h"
 #include "util/language.h"

src/creport.c

@@ -1,4 +1,6 @@
-#include <platform.h>
+#ifdef _MSC_VER
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #include <kernel/config.h>
 #include <kernel/version.h>
 #include "creport.h"

src/economy.c

@@ -1,4 +1,5 @@
 #ifdef _MSC_VER
+#define _CRT_SECURE_NO_WARNINGS
 #include <platform.h>
 #endif
 

src/exparse.c

@@ -1,5 +1,5 @@
 #ifdef _MSC_VER
-#include <platform.h>
+#define _CRT_SECURE_NO_WARNINGS
 #endif
 #include "exparse.h"
 

src/gmtool.c

@@ -1,7 +1,8 @@
 #ifdef _MSC_VER
-#include <platform.h>
+#ifndef _CRT_SECURE_NO_WARNINGS
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #endif
-
 #include <curses.h>
 
 #include "gmtool.h"

src/json.c

@@ -1,5 +1,6 @@
-#include "platform.h"
-
+#ifdef _MSC_VER
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #include "json.h"
 
 #include <util/base36.h>

src/jsonconf.c

@@ -1,4 +1,6 @@
-#include <platform.h>
+#ifdef _MSC_VER
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #include "jsonconf.h"
 
 /* kernel includes */
@@ -47,22 +49,37 @@
 #include <stdlib.h>
 #include <string.h>
 
-static int json_flags(cJSON *json, const char *flags[]) {
-    cJSON *entry;
-    int result = 0;
-    assert(json->type == cJSON_Array);
-    for (entry = json->child; entry; entry = entry->next) {
-        if (entry->type == cJSON_String) {
+static void json_map(void* object, void (*mapfun)(void* child, void* udata), void* udata)
+{
+    cJSON *child, *json = (cJSON*)object;
+    for (child = json->child; child; child = child->next) {
+        mapfun(child, udata);
+    }
+}
+
+struct flags {
+    const char** names;
+    int result;
+};
+
+static void cb_flags(void* json, struct flags* flags)
+{
+    cJSON* entry = (cJSON*)json;
     int i;
-            for (i = 0; flags[i]; ++i) {
-                if (strcmp(flags[i], entry->valuestring) == 0) {
-                    result |= (1 << i);
+    for (i = 0; flags->names[i]; ++i) {
+        if (strcmp(flags->names[i], entry->valuestring) == 0) {
+            flags->result |= (1 << i);
             break;
         }
     }
-        }
-    }
-    return result;
+}
+
+static int json_flags(cJSON *json, const char *flags[]) {
+    struct flags ctx = { flags, 0 };
+
+    assert(json->type == cJSON_Array);
+    json_map(json, cb_flags, &ctx);
+    return ctx.result;
 }
 
 static void json_requirements(cJSON *json, requirement **matp) {

src/jsonconf.test.c

@@ -1,5 +1,7 @@
 #ifdef _MSC_VER
-#include <platform.h>
+#ifndef _CRT_SECURE_NO_WARNINGS
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #endif
 
 #include "kernel/types.h"

src/kernel/ally.c

@@ -1,4 +1,6 @@
-#include "platform.h"
+#ifdef _MSC_VER
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #include "config.h"
 #include "ally.h"
 

src/kernel/attrib.c

@@ -94,33 +94,18 @@ void a_writechars(const variant * var, const void *owner, struct storage *store)
 int a_readstring(variant * var, void *owner, struct gamedata *data)
 {
     char buf[DISPLAYSIZE];
-    char * result = 0;
-    int e;
-    size_t len = 0;
-    do {
-        e = READ_STR(data->store, buf, sizeof(buf));
-        if (result) {
-            char *tmp = realloc(result, len + DISPLAYSIZE - 1);
-            if (!tmp) {
-                free(result);
-                abort();
-            }
-            result = tmp;
-            strcpy(result + len, buf);
-            len += DISPLAYSIZE - 1;
-        }
-        else {
-            result = str_strdup(buf);
-        }
-    } while (e == ENOMEM);
-    var->v = result;
+
+    READ_STR(data->store, buf, sizeof(buf));
+    var->v = str_strdup(buf);
     return AT_READ_OK;
 }
 
 void a_writestring(const variant * var, const void *owner, struct storage *store)
 {
+    const char* str = (const char*)var->v;
     assert(var && var->v);
-    WRITE_STR(store, (const char *)var->v);
+    assert(strlen(str) < DISPLAYSIZE);
+    WRITE_STR(store, str);
 }
 
 void a_finalizestring(variant * var)

src/kernel/config.c

@@ -1,7 +1,6 @@
 #ifdef _MSC_VER
-#include <platform.h>
+#define _CRT_SECURE_NO_WARNINGS
 #endif
-
 #include "config.h"
 
 /* kernel includes */

src/kernel/db/sqlite.c

@@ -1,5 +1,6 @@
-#include <platform.h>
-
+#ifdef _MSC_VER
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #include <kernel/config.h>
 
 #include <util/log.h>

src/kernel/faction.c

@@ -1,5 +1,6 @@
-#include <platform.h>
-
+#ifdef _MSC_VER
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #include "faction.h"
 
 #include "calendar.h"

src/kernel/faction.test.c

@@ -1,5 +1,8 @@
-#include <platform.h>
-
+#ifdef _MSC_VER
+#ifndef _CRT_SECURE_NO_WARNINGS
+#define _CRT_SECURE_NO_WARNINGS
+#endif
+#endif
 #include <kernel/ally.h>
 #include <kernel/alliance.h>
 #include <kernel/calendar.h>

src/kernel/gamedata.c

@@ -1,5 +1,6 @@
-#include <platform.h>
-
+#ifdef _MSC_VER
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #include "gamedata.h"
 
 #include <util/log.h>

src/kernel/item.c

@@ -1,4 +1,6 @@
-#include <platform.h>
+#ifdef _MSC_VER
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #include <kernel/config.h>
 #include "item.h"
 

src/kernel/messages.c

@@ -1,4 +1,6 @@
-#include <platform.h>
+#ifdef _MSC_VER
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #include "messages.h"
 
 /* kernel includes */

src/kernel/order.c

@@ -1,7 +1,6 @@
 #ifdef _MSC_VER
-#include <platform.h>
+#define _CRT_SECURE_NO_WARNINGS
 #endif
-
 #include <kernel/config.h>
 #include "order.h"
 

src/kernel/race.c

@@ -1,4 +1,6 @@
-#include <platform.h>
+#ifdef _MSC_VER
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #include <kernel/config.h>
 #include "race.h"
 

src/kernel/race.test.c

@@ -1,4 +1,8 @@
-#include <platform.h>
+#ifdef _MSC_VER
+#ifndef _CRT_SECURE_NO_WARNINGS
+#define _CRT_SECURE_NO_WARNINGS
+#endif
+#endif
 #include "faction.h"
 #include "unit.h"
 #include "race.h"

src/kernel/save.c

@@ -1,4 +1,6 @@
-#include <platform.h>
+#ifdef _MSC_VER
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #include <kernel/config.h>
 #include <kernel/version.h>
 #include "save.h"

src/kernel/save.test.c

@@ -1,4 +1,8 @@
-#include <platform.h>
+#ifdef _MSC_VER
+#ifndef _CRT_SECURE_NO_WARNINGS
+#define _CRT_SECURE_NO_WARNINGS
+#endif
+#endif
 #include <kernel/config.h>
 #include <kernel/race.h>
 #include <attributes/key.h>

src/kernel/unit.test.c

@@ -1,3 +1,8 @@
+#ifdef _MSC_VER
+#ifndef _CRT_SECURE_NO_WARNINGS
+#define _CRT_SECURE_NO_WARNINGS
+#endif
+#endif
 #include <kernel/ally.h>
 #include <kernel/config.h>
 #include <kernel/curse.h>

src/kernel/version.c

@@ -1,5 +1,5 @@
 #ifdef _MSC_VER
-#include <platform.h>
+#define _CRT_SECURE_NO_WARNINGS
 #endif
 #include "version.h"
 

src/laws.c

@@ -1,5 +1,5 @@
 #ifdef _MSC_VER
-#include <platform.h>
+#define _CRT_SECURE_NO_WARNINGS
 #endif
 #include <kernel/config.h>
 #include "laws.h"

src/magic.c

@@ -1,5 +1,5 @@
 #ifdef _MSC_VER
-#include <platform.h>
+#define _CRT_SECURE_NO_WARNINGS
 #endif
 #include "magic.h"
 

src/main.c

@@ -1,3 +1,9 @@
+#ifdef _MSC_VER
+#ifndef _CRT_SECURE_NO_WARNINGS
+#define _CRT_SECURE_NO_WARNINGS
+#endif
+#endif
+
 #include <kernel/calendar.h>
 #include <kernel/config.h>
 #include <kernel/messages.h>

src/modules/autoseed.c

@@ -1,4 +1,6 @@
-#include <platform.h>
+#ifdef _MSC_VER
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #include <kernel/config.h>
 #include "autoseed.h"
 

src/modules/score.c

@@ -1,4 +1,6 @@
-#include <platform.h>
+#ifdef _MSC_VER
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #include <kernel/config.h>
 #include "score.h"
 

src/names.c

@@ -1,4 +1,6 @@
-#include <platform.h>
+#ifdef _MSC_VER
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #include <kernel/config.h>
 #include "names.h"
 

src/orderfile.test.c

@@ -1,4 +1,8 @@
-#include <platform.h>
+#ifdef _MSC_VER
+#ifndef _CRT_SECURE_NO_WARNINGS
+#define _CRT_SECURE_NO_WARNINGS
+#endif
+#endif
 #include <kernel/config.h>
 
 #include "orderfile.h"

src/report.c

@@ -1,5 +1,5 @@
 #ifdef _MSC_VER
-#include <platform.h>
+#define _CRT_SECURE_NO_WARNINGS
 #endif
 
 #include "report.h"

src/reports.c

@@ -1,5 +1,5 @@
 #ifdef _MSC_VER
-#include <platform.h>
+#define _CRT_SECURE_NO_WARNINGS
 #endif
 #include "reports.h"
 

src/skill.c

@@ -1,4 +1,6 @@
-#include <platform.h>
+#ifdef _MSC_VER
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #include <kernel/config.h>
 #include "skill.h"
 

src/study.c

@@ -1,5 +1,5 @@
 #ifdef _MSC_VER
-#include <platform.h>
+#define _CRT_SECURE_NO_WARNINGS
 #endif
 #include <kernel/config.h>
 #include "study.h"

src/summary.c

@@ -1,5 +1,5 @@
 #ifdef _MSC_VER
-#include <platform.h>
+#define _CRT_SECURE_NO_WARNINGS
 #endif
 #include <kernel/config.h>
 

src/tests.c

@@ -1,4 +1,8 @@
-#include <platform.h>
+#ifdef _MSC_VER
+#ifndef _CRT_SECURE_NO_WARNINGS
+#define _CRT_SECURE_NO_WARNINGS
+#endif
+#endif
 #include "tests.h"
 #include "prefix.h"
 #include "creport.h"

src/util/crmessage.c

@@ -1,4 +1,6 @@
-#include <platform.h>
+#ifdef _MSC_VER
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #include "crmessage.h"
 
 #include "macros.h"

src/util/crypto/CMakeLists.txt

@@ -1,26 +1,28 @@
+cmake_minimum_required(VERSION 2.9)
 project (crypto C)
 
-IF (MSVC)
-  include (MSVC)
-  MSVC_SET_WARNING_LEVEL(3)
-ENDIF (MSVC)
+if (MSVC)
+  #add_compile_definitions (_CRT_SECURE_NO_WARNINGS)
+  add_compile_options(/WX)
+  if(CMAKE_C_FLAGS MATCHES "/W[0-4]")
+    string(REGEX REPLACE "/W[0-4]" "/W3" CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")
+  else()
+    add_compile_options(/W3)
+  endif()
+endif (MSVC)
 
-SET (LIB_SRC
+set (LIB_SRC
   crypto.c
   crypt_blowfish/wrapper.c
   crypt_blowfish/crypt_blowfish.c
   crypt_blowfish/crypt_gensalt.c
 )
-ADD_LIBRARY (crypto ${LIB_SRC})
+add_library (crypto ${LIB_SRC})
 
 set (CRYPTO_INCLUDE_DIR ${CMAKE_CURRENT_SOURCE_DIR} CACHE INTERNAL "crypto headers")
 set (CRYPTO_LIBRARIES crypto CACHE INTERNAL "crypto libraries")
 
-IF(WIN32)
-  SET(CRYPTO_LIBRARIES ${CRYPTO_LIBRARIES} bcrypt CACHE
+if(WIN32)
+  set(CRYPTO_LIBRARIES ${CRYPTO_LIBRARIES} bcrypt CACHE
     INTERNAL "crypto libraries")
-ENDIF()
-            
-IF (MSVC)
-  MSVC_CRT_SECURE_NO_WARNINGS (crypto)
-ENDIF (MSVC)
+endif()

src/util/keyword.c

@@ -1,4 +1,6 @@
-#include <platform.h>
+#ifdef _MSC_VER
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #include <kernel/config.h>
 #include "keyword.h"
 

src/util/language.c

@@ -1,7 +1,6 @@
 #ifdef _MSC_VER
-#include <platform.h>
+#define _CRT_SECURE_NO_WARNINGS
 #endif
-
 #include "language.h"
 
 #include "log.h"

src/util/log.c

@@ -1,3 +1,6 @@
+#ifdef _MSC_VER
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #include "log.h"
 
 #include "path.h"

src/util/log.test.c

@@ -1,7 +1,8 @@
 #ifdef _MSC_VER
-#include <platform.h>
+#ifndef _CRT_SECURE_NO_WARNINGS
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #endif
-
 #include "log.h"
 #include "stats.h"
 #include "macros.h"

src/util/order_parser.test.c

@@ -1,7 +1,8 @@
 #ifdef _MSC_VER
-#include <platform.h>
+#ifndef _CRT_SECURE_NO_WARNINGS
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #endif
-
 #include "order_parser.h"
 #include "strings.h"
 

src/util/pofile.c

@@ -1,7 +1,6 @@
 #ifdef _MSC_VER
-#include <platform.h>
+#define _CRT_SECURE_NO_WARNINGS
 #endif
-
 #include "pofile.h"
 #include "log.h"
 #include "strings.h"

src/util/strings.test.c

@@ -1,5 +1,7 @@
 #ifdef _MSC_VER
-#include <platform.h>
+#ifndef _CRT_SECURE_NO_WARNINGS
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #endif
 #include <CuTest.h>
 

src/util/unicode.test.c

@@ -1,7 +1,8 @@
 #ifdef _MSC_VER
-#include <platform.h>
+#ifndef _CRT_SECURE_NO_WARNINGS
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 #endif
-
 #include "unicode.h"
 
 #include <CuTest.h>

storage

@@ -1 +1 @@
-Subproject commit 1f558529f7393c743c346a679d050d5f4ed19f14
+Subproject commit 629e578a7f912580933da26d8dc2c27804992fb3

tolua

@@ -1 +1 @@
-Subproject commit a3dec42d329dabcfe0a19c9bba506f7074883dba
+Subproject commit 7c73f64e0a0001f49f04c51921e4c15167e4e67b

vs2019-build.bat

@@ -1,7 +1,5 @@
 @ECHO OFF
-IF "%WIN32_DEV%" == "" SET WIN32_DEV="C:\Libraries"
 SET CMAKE_ROOT=%ProgramFiles%\CMake
-IF "%LUA_DEV%" == "" SET LUA_DEV="%ProgramFiles(x86)%/Lua/5.1"
 SET VSVERSION=16
 SET SRCDIR=%CD%
 REM CD ..
@@ -17,5 +15,5 @@ cd build-vs%VSVERSION%
 IF NOT EXIST CMakeCache.txt GOTO NOCACHE
 DEL CMakeCache.txt
 :NOCACHE
-"%CMAKE_ROOT%\bin\cmake.exe" -DCMAKE_TOOLCHAIN_FILE=C:/vcpkg/scripts/buildsystems/vcpkg.cmake -A Win32 -G "Visual Studio %VSVERSION%" -DCMAKE_PREFIX_PATH="%LUA_DEV%;%WIN32_DEV%" -DCMAKE_MODULE_PATH="%CMAKE_MODULES%" -DCMAKE_SUPPRESS_REGENERATION=TRUE ..
+"%CMAKE_ROOT%\bin\cmake.exe" -DCMAKE_TOOLCHAIN_FILE=C:/vcpkg/scripts/buildsystems/vcpkg.cmake -A x64 -G "Visual Studio %VSVERSION%" -DCMAKE_MODULE_PATH="%CMAKE_MODULES%" -DCMAKE_SUPPRESS_REGENERATION=TRUE ..
 PAUSE