Marc
/
server
forked from github/server
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

CID 22565: Copy into fixed size buffer (STRING_OVERFLOW) 

bsdstring to the rescue
This commit is contained in:
Enno Rehling 2015-10-30 11:11:54 +01:00
parent b8d7fa5bcc
commit df82a9795d
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/modules/autoseed.c
View File

@ -31,6 +31,7 @@
/* util includes */ /* util includes */
#include <util/attrib.h> #include <util/attrib.h>
#include <util/base36.h> #include <util/base36.h>
#include <util/bsdstring.h>
#include <util/goodies.h> #include <util/goodies.h>
#include <util/language.h> #include <util/language.h>
#include <util/lists.h> #include <util/lists.h>
@ -186,8 +187,9 @@ newfaction *read_newfactions(const char *filename)
if (email[0] == '\0') if (email[0] == '\0')
break; break;
if (password[0] == '\0') { if (password[0] == '\0') {
strcpy(password, itoa36(rng_int())); size_t sz;
strcat(password, itoa36(rng_int())); sz = strlcpy(password, itoa36(rng_int()), sizeof(password));
sz += strlcat(password, itoa36(rng_int()), sizeof(password));
} }
for (f = factions; f; f = f->next) { for (f = factions; f; f = f->next) {
if (strcmp(f->email, email) == 0 && f->subscription if (strcmp(f->email, email) == 0 && f->subscription