From 9ff98b5b23d75df196d325fbd01ea04312fc2f5d Mon Sep 17 00:00:00 2001
From: Enno Rehling <enno.rehling@gmail.com>
Date: Fri, 13 Oct 2017 19:32:31 +0200
Subject: [PATCH] more fine-grained testing for cansee

---
 src/laws.test.c | 23 ++++++++++++++++++++---
 1 file changed, 20 insertions(+), 3 deletions(-)

diff --git a/src/laws.test.c b/src/laws.test.c
index 87d5838b9..ec14ac4cc 100644
--- a/src/laws.test.c
+++ b/src/laws.test.c
@@ -1590,12 +1590,28 @@ static void test_cansee(CuTest *tc) {
 
     set_level(u2, SK_STEALTH, 1);
     CuAssertTrue(tc, !cansee(u->faction, u->region, u2, 0, seen_unit));
-    CuAssertTrue(tc, !cansee(u->faction, u->region, u2, 0, seen_spell));
-    CuAssertTrue(tc, cansee(u->faction, u->region, u2, 1, seen_spell));
 
     set_level(u, SK_PERCEPTION, 1);
     CuAssertTrue(tc, cansee(u->faction, u->region, u2, 0, seen_unit));
-    CuAssertTrue(tc, !cansee(u->faction, u->region, u2, 0, seen_spell));
+
+    test_cleanup();
+}
+
+static void test_cansee_spell(CuTest *tc) {
+    unit *u2;
+    faction *f;
+
+    test_setup();
+    f = test_create_faction(0);
+    u2 = test_create_unit(test_create_faction(0), test_create_region(0, 0, 0));
+
+    CuAssertTrue(tc, cansee(f, u2->region, u2, 0, seen_spell));
+    CuAssertTrue(tc, cansee(f, u2->region, u2, 0, seen_battle));
+
+    set_level(u2, SK_STEALTH, 1);
+    CuAssertTrue(tc, !cansee(f, u2->region, u2, 0, seen_spell));
+    CuAssertTrue(tc, cansee(f, u2->region, u2, 1, seen_spell));
+    CuAssertTrue(tc, cansee(f, u2->region, u2, 1, seen_battle));
 
     test_cleanup();
 }
@@ -1738,6 +1754,7 @@ CuSuite *get_laws_suite(void)
     SUITE_ADD_TEST(suite, test_demon_hunger);
     SUITE_ADD_TEST(suite, test_armedmen);
     SUITE_ADD_TEST(suite, test_cansee);
+    SUITE_ADD_TEST(suite, test_cansee_spell);
     SUITE_ADD_TEST(suite, test_cansee_items);
 
     return suite;