From ee1d97df19c4df42a02c19d8b9012b8dc6beb120 Mon Sep 17 00:00:00 2001
From: Enno Rehling <enno.rehling@gmail.com>
Date: Tue, 1 Jul 2014 20:36:31 -0700
Subject: [PATCH] remov e the old recycling quota, it was always 0.5
 everywhere, and a silly feature..

---
 src/kernel/build.c         | 6 +-----
 src/kernel/build.h         | 1 -
 src/kernel/jsonconf.c      | 1 -
 src/kernel/jsonconf.test.c | 1 -
 src/kernel/xmlreader.c     | 1 -
 5 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/src/kernel/build.c b/src/kernel/build.c
index 7988293ef..6fb17c859 100644
--- a/src/kernel/build.c
+++ b/src/kernel/build.c
@@ -66,10 +66,6 @@ OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 #include <attributes/matmod.h>
 #include <attributes/alliance.h>
 
-#define STONERECYCLE 50
-/* Name, MaxGroesse, MinBauTalent, Kapazitaet, {Eisen, Holz, Stein, BauSilber,
- * Laen, Mallorn}, UnterSilber, UnterSpezialTyp, UnterSpezial */
-
 struct building *getbuilding(const struct region *r)
 {
   building *b = findbuilding(getid());
@@ -240,7 +236,7 @@ int destroy_cmd(unit * u, struct order *ord)
     int c;
     for (c = 0; con->materials[c].number; ++c) {
       const requirement *rq = con->materials + c;
-      int recycle = (int)(rq->recycle * rq->number * size / con->reqsize);
+      int recycle = (rq->number * size / con->reqsize)/2;
       if (recycle) {
         change_resource(u, rq->rtype, recycle);
       }
diff --git a/src/kernel/build.h b/src/kernel/build.h
index a4afb5d81..e08e5f65e 100644
--- a/src/kernel/build.h
+++ b/src/kernel/build.h
@@ -37,7 +37,6 @@ extern "C" {
   typedef struct requirement {
     const struct resource_type *rtype;
     int number;
-    double recycle;             /* recycling quota */
   } requirement;
 
   typedef struct construction {
diff --git a/src/kernel/jsonconf.c b/src/kernel/jsonconf.c
index bdf12e431..0e36ad8f7 100644
--- a/src/kernel/jsonconf.c
+++ b/src/kernel/jsonconf.c
@@ -75,7 +75,6 @@ static void json_requirements(cJSON *json, requirement **matp) {
     requirement *mat = calloc(sizeof(requirement), 1+cJSON_GetArraySize(json));
     for (i=0,child=json->child;child;child=child->next,++i) {
         mat[i].number = child->valueint;
-        mat[i].recycle = 0.5f;
         mat[i].rtype = rt_get_or_create(child->string);
     }
     *matp = mat;
diff --git a/src/kernel/jsonconf.test.c b/src/kernel/jsonconf.test.c
index 1d9780f90..e422d4e63 100644
--- a/src/kernel/jsonconf.test.c
+++ b/src/kernel/jsonconf.test.c
@@ -204,7 +204,6 @@ static void test_buildings(CuTest * tc)
     CuAssertPtrNotNull(tc, bt->construction);
     CuAssertPtrNotNull(tc, bt->construction->materials);
     CuAssertIntEquals(tc, 2, bt->construction->materials[0].number);
-    CuAssertDblEquals(tc, 0.5f, bt->construction->materials[0].recycle, 0.0f);
     CuAssertPtrEquals(tc, (void *)get_resourcetype(R_STONE), (void *)bt->construction->materials[0].rtype);
     CuAssertIntEquals(tc, 1, bt->construction->materials[1].number);
     CuAssertPtrEquals(tc, (void *)get_resourcetype(R_IRON), (void *)bt->construction->materials[1].rtype);
diff --git a/src/kernel/xmlreader.c b/src/kernel/xmlreader.c
index d5ea7bc78..3d5c962eb 100644
--- a/src/kernel/xmlreader.c
+++ b/src/kernel/xmlreader.c
@@ -122,7 +122,6 @@ xml_readrequirements(xmlNodePtr * nodeTab, int nodeNr, requirement ** reqArray)
     xmlChar *propValue;
 
     radd->number = xml_ivalue(node, "quantity", 1);
-    radd->recycle = xml_fvalue(node, "recycle", 0.5);
 
     propValue = xmlGetProp(node, BAD_CAST "type");
     radd->rtype = rt_get_or_create((const char *)propValue);