properly create missing monster faction when spawning dragons.

src/kernel/faction.c

@@ -1,7 +1,7 @@
 /*
 Copyright (c) 1998-2010, Enno Rehling <enno@eressea.de>
-                         Katja Zedel <katze@felidae.kn-bremen.de
+Katja Zedel <katze@felidae.kn-bremen.de
-                         Christian Schlittchen <corwin@amber.kn-bremen.de>
+Christian Schlittchen <corwin@amber.kn-bremen.de>
 
 Permission to use, copy, modify, and/or distribute this software for any
 purpose with or without fee is hereby granted, provided that the above
@@ -105,40 +105,44 @@ void set_show_item(faction * f, const struct item_type *itype)
     a->data.v = (void *)itype;
 }
 
-faction *get_monsters(void)
+static faction *monsters;
-{
-  static faction *monsters;
-  static int gamecookie = -1;
 
-  if (gamecookie != global.cookie) {
+faction *get_monsters(void) {
-    monsters = NULL;
-    gamecookie = global.cookie;
-  }
-
-  if (!monsters) {
     faction *f;
+
     for (f = factions; f; f = f->next) {
         if ((f->flags & FFL_NPC) && !(f->flags & FFL_DEFENDER)) {
             return monsters = f;
         }
     }
-    if (!monsters) {
+    return 0;
-      /* shit! */
+}
-      monsters = findfaction(666);
+
+faction *get_or_create_monsters(void)
+{
+    faction *f = get_monsters();
+    static int gamecookie = -1;
+    if (gamecookie != global.cookie) {
+        monsters = NULL;
+        gamecookie = global.cookie;
     }
-    if (!monsters) {
+
+    if (!f) {
+        /* shit! */
+        f = findfaction(666);
+    }
+    if (!f) {
         const race *rc = rc_find("dragon");
-        faction *f = addfaction("noreply@eressea.de", NULL, rc, NULL, 0);
+            
+        f = addfaction("noreply@eressea.de", NULL, rc, NULL, 0);
         renumber_faction(f, 666);
         faction_setname(f, "Monster");
         f->options = 0;
-        monsters = f;
     }
-    if (monsters) {
+    if (f) {
-      fset(monsters, FFL_NPC | FFL_NOIDLEOUT);
+        fset(f, FFL_NPC | FFL_NOIDLEOUT);
     }
-  }
+    return monsters = f;
-  return monsters;
 }
 
 const unit *random_unit_in_faction(const faction * f)
@@ -170,7 +174,8 @@ const char *factionname(const faction * f)
 
     if (f && f->name) {
         slprintf(ibuf, sizeof(name), "%s (%s)", f->name, itoa36(f->no));
-  } else {
+    }
+    else {
         strcpy(ibuf, "Unbekannte Partei (?)");
     }
     return ibuf;
@@ -186,7 +191,7 @@ int resolve_faction(variant id, void *address)
             result = -1;
         }
     }
-  *(faction **) address = f;
+    *(faction **)address = f;
     return result;
 }
 
@@ -211,7 +216,6 @@ faction *addfaction(const char *email, const char *password,
     faction *f = calloc(sizeof(faction), 1);
     char buf[128];
 
-  assert(frace || !"cannot create a faction that has no race");
     if (set_email(&f->email, email) != 0) {
         log_error("Invalid email address for faction %s: %s\n", itoa36(f->no), email);
     }
@@ -242,6 +246,10 @@ faction *addfaction(const char *email, const char *password,
     slprintf(buf, sizeof(buf), "%s %s", LOC(loc, "factiondefault"), factionid(f));
     f->name = _strdup(buf);
 
+    if (!f->race) {
+        log_warning("creating a faction that has no race", factionid(f));
+    }
+
     return f;
 }
 
@@ -263,7 +271,7 @@ unit *addplayer(region * r, faction * f)
         race_t urc;
         race *rc;
         do {
-      urc = (race_t) (rng_int() % MAXRACES);
+            urc = (race_t)(rng_int() % MAXRACES);
             rc = get_race(urc);
         } while (rc == NULL || urc == RC_DAEMON || !playerrace(rc));
         u->irace = rc;
@@ -322,7 +330,8 @@ void destroyfaction(faction * f)
             unit *zombie = u;
             u = u->nextF;
             make_zombie(zombie);
-    } else {
+        }
+        else {
             region *r = u->region;
 
             if (!fval(r->terrain, SEA_REGION) && !!playerrace(u_race(u))) {
@@ -338,7 +347,8 @@ void destroyfaction(faction * f)
                      * stammen */
                     if (rc->ec_flags & ECF_REC_HORSES) {  /* Zentauren an die Pferde */
                         h += u->number;
-          } else {              /* Orks zählen nur zur Hälfte */
+                    }
+                    else {              /* Orks zählen nur zur Hälfte */
                         p += (int)(u->number * rc->recruit_multi);
                     }
                     for (itm = u->items; itm; itm = itm->next) {
@@ -357,7 +367,7 @@ void destroyfaction(faction * f)
         }
     }
     f->alive = 0;
-/* no way!  f->units = NULL; */
+    /* no way!  f->units = NULL; */
     handle_event(f->attribs, "destroy", f);
     for (ff = factions; ff; ff = ff->next) {
         group *g;
@@ -505,7 +515,7 @@ bool valid_race(const struct faction *f, const struct race *rc)
     else {
         const char *str = get_param(f->race->parameters, "other_race");
         if (str)
-      return (bool) (rc_find(str) == rc);
+            return (bool)(rc_find(str) == rc);
         return false;
     }
 }
@@ -528,7 +538,7 @@ struct spellbook * faction_get_spellbook(struct faction *f)
     if (f->spellbook) {
         return f->spellbook;
     }
-  if (f->magiegebiet!=M_GRAY) {
+    if (f->magiegebiet != M_GRAY) {
         return get_spellbook(magic_school[f->magiegebiet]);
     }
     return 0;
@@ -542,7 +552,7 @@ static int allied_skillcount(const faction * f, skill_t sk)
     int qi;
 
     for (qi = 0; members; ql_advance(&members, &qi, 1)) {
-    faction *m = (faction *) ql_get(members, qi);
+        faction *m = (faction *)ql_get(members, qi);
         num += count_skill(m, sk);
     }
     return num;
@@ -591,7 +601,8 @@ int skill_limit(faction * f, skill_t sk)
     }
     if (sk == SK_MAGIC) {
         m = max_magicians(f);
-  } else if (sk == SK_ALCHEMY) {
+    }
+    else if (sk == SK_ALCHEMY) {
         m = get_param_int(global.parameters, "rules.maxskills.alchemy",
             MAXALCHEMISTS);
     }

src/kernel/faction.h

@@ -114,6 +114,7 @@ typedef struct faction {
 extern struct faction *factions;
 
 struct faction *get_monsters(void);
+struct faction *get_or_create_monsters(void);
 int max_magicians(const faction * f);
 void set_show_item(faction * f, const struct item_type *itype);
 

src/monsters.c

@@ -889,7 +889,7 @@ static int nrand(int start, int sub)
 void spawn_dragons(void)
 {
   region *r;
-  faction *monsters = get_monsters();
+  faction *monsters = get_or_create_monsters();
 
   for (r = regions; r; r = r->next) {
     unit *u;