From 810ad094afc4a83be3d08329eb10c2886c33f284 Mon Sep 17 00:00:00 2001
From: Enno Rehling <enno.rehling@gmail.com>
Date: Fri, 18 Dec 2015 15:13:15 +0100
Subject: [PATCH] suppress misc warnings in the log file by reorganizing E3
 strings and tuning down log levels

---
 res/core/de/strings.xml      | 10 ++++++++++
 res/eressea/strings.xml      |  8 --------
 scripts/eressea/autoseed.lua |  2 +-
 scripts/newplayer.lua        |  2 +-
 src/kernel/save.c            |  8 ++++----
 5 files changed, 16 insertions(+), 14 deletions(-)

diff --git a/res/core/de/strings.xml b/res/core/de/strings.xml
index 090344483..f384f3a23 100644
--- a/res/core/de/strings.xml
+++ b/res/core/de/strings.xml
@@ -21,6 +21,12 @@
     Ruderschwanz und einem riesigen runden Maul zu bestehen scheint.</text>
     <text locale="en">Wobbling green vapours drift through the mists to form an eldritch creature that seems to be entirely made up of huge jaws and a long tail.</text>
   </string>
+  <namespace name="shipinfo">
+    <string name="no_info">
+      <text locale="de">Keine Informationen über diesen Schiffstyp verfügbar.</text>
+      <text locale="en">No Information available for this type of ship.</text>
+    </string>
+  </namespace>
   <namespace name="raceinfo">
     <string name="no_info">
       <text locale="de">Keine Informationen über diese Rasse verfügbar.</text>
@@ -62,6 +68,10 @@
     </string>
   </namespace>
   <namespace name="iteminfo">
+    <string name="no_info">
+      <text locale="de">Keine Informationen.</text>
+      <text locale="en">No Information available.</text>
+    </string>
     <string name="trollspoil">
       <text locale="de">Das Horn eines Trolles. Kein Troll würde sich lebend davon trennen.</text>
       <text locale="en">The horn of an adult troll. No troll would ever part with this while he's alive.</text>
diff --git a/res/eressea/strings.xml b/res/eressea/strings.xml
index 8c77d9e82..7e444e8e3 100644
--- a/res/eressea/strings.xml
+++ b/res/eressea/strings.xml
@@ -103,10 +103,6 @@
   </namespace>
   <namespace name="shipinfo">
     <!-- ship info is not implemented! -->
-    <string name="no_info">
-      <text locale="de">Keine Informationen über diesen Schiffstyp verfügbar.</text>
-      <text locale="en">No Information available for this type of ship.</text>
-    </string>
     <string name="balloon">
       <text locale="de">Der Sumpfgasballon besteht aus einem großen 
         Weidenkorb, welcher Platz
@@ -128,10 +124,6 @@
       <text locale="de">Eine Geburtstagstorte mit 10 Kerzen. Herzlichen Glückwunsch, Eressea!</text>
       <text locale="en">A birthday cake with 10 candles. Happy Birthday, Eressea!</text>
     </string>
-    <string name="no_info">
-      <text locale="de">Keine Informationen.</text>
-      <text locale="en">No Information available.</text>
-    </string>
     <string name="griphonwing">
       <text locale="de">Dieses Fluggerät aus der Schmiede der Zwerge von Celeband galt wie die
         'Ebene der Herausforderung' seit Urzeiten als verschollen, ja man
diff --git a/scripts/eressea/autoseed.lua b/scripts/eressea/autoseed.lua
index 733df06f8..35c7f0e34 100644
--- a/scripts/eressea/autoseed.lua
+++ b/scripts/eressea/autoseed.lua
@@ -88,7 +88,7 @@ function autoseed.init()
             end
             local dupe = get_faction_by_email(p.email)
             if dupe then
-                eressea.log.warning("seed: duplicate email " .. p.email .. " already used by faction " .. tostring(dupe))
+                eressea.log.warning("seed: duplicate email " .. p.email .. " already used by " .. tostring(dupe))
             else
                 local f = seed(start, p.email, p.race or "human", p.lang or "de")
                 num_seeded = num_seeded + 1
diff --git a/scripts/newplayer.lua b/scripts/newplayer.lua
index 45df076d6..9e536595b 100644
--- a/scripts/newplayer.lua
+++ b/scripts/newplayer.lua
@@ -72,7 +72,7 @@ for _, p in ipairs(players) do
     local dupe = false
     for f in factions() do
         if f.email==p.email then
-            print("seed: duplicate email " .. p.email .. " already used by faction " .. tostring(f))
+            print("seed: duplicate email " .. p.email .. " already used by " .. tostring(f))
             dupe = true
             break
         end
diff --git a/src/kernel/save.c b/src/kernel/save.c
index d4df2b6f8..afcb6c988 100644
--- a/src/kernel/save.c
+++ b/src/kernel/save.c
@@ -712,11 +712,11 @@ unit *read_unit(struct gamedata *data)
                         ord = NULL;
                     }
                     else if (p == MAXPERSISTENT) {
-                        log_warning("%s had %d or more persistent orders\n", unitname(u), MAXPERSISTENT);
+                        log_info("%s had %d or more persistent orders\n", unitname(u), MAXPERSISTENT);
                     }
                 }
                 else if (n == MAXORDERS) {
-                    log_warning("%s had %d or more orders\n", unitname(u), MAXORDERS);
+                    log_info("%s had %d or more orders\n", unitname(u), MAXORDERS);
                 }
                 if (ord != NULL)
                     free_order(ord);
@@ -779,7 +779,7 @@ void write_unit(struct gamedata *data, const unit * u)
             writeorder(data, ord, u->faction->locale);
         }
         else {
-            log_warning("%s had %d or more persistent orders\n", unitname(u), MAXPERSISTENT);
+            log_info("%s had %d or more persistent orders\n", unitname(u), MAXPERSISTENT);
             break;
         }
     }
@@ -792,7 +792,7 @@ void write_unit(struct gamedata *data, const unit * u)
                 writeorder(data, ord, u->faction->locale);
             }
             else {
-                log_warning("%s had %d or more persistent orders\n", unitname(u), MAXPERSISTENT);
+                log_info("%s had %d or more persistent orders\n", unitname(u), MAXPERSISTENT);
                 break;
             }
         }