Marc/server
1
0
Fork 0
forked from github/server
Code Issues Pull requests Projects Releases Wiki Activity

coverity scan CID 22553: dereference before null check

Browse source
This commit is contained in:
Enno Rehling 2015-10-29 08:51:53 +01:00
parent e60b739ea4
commit 70d4a6af03
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/kernel/xmlreader.c
View file

@ -929,12 +929,14 @@ static int parse_resources(xmlDocPtr doc)
flags |= RTF_LIMITED; flags |= RTF_LIMITED;
name = xmlGetProp(node, BAD_CAST "name"); name = xmlGetProp(node, BAD_CAST "name");
assert(name != NULL); if (!name) {
assert(name);
log_error("invalid resource %d has no name", i);
continue;
}
rtype = rt_get_or_create((const char *)name); rtype = rt_get_or_create((const char *)name);
rtype->flags |= flags; rtype->flags |= flags;
xmlFree(name);
if (name) xmlFree(name);
name = xmlGetProp(node, BAD_CAST "material"); name = xmlGetProp(node, BAD_CAST "material");
if (name) { if (name) {