From 03a8b7383cd41ed499abb67dc305b52d3bb17389 Mon Sep 17 00:00:00 2001
From: Enno Rehling <enno.rehling@gmail.com>
Date: Fri, 5 Aug 2016 20:15:05 +0200
Subject: [PATCH 1/2] fix log_rotate warnings (#529)

* ignore file-not-found errors when trying to rotate logs.
I suspect this is faster and safer than testing existence.

* block rename warnings, part deux
---
 src/util/log.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/util/log.c b/src/util/log.c
index 1399ce562..ee3909a01 100644
--- a/src/util/log.c
+++ b/src/util/log.c
@@ -93,7 +93,7 @@ cp_convert(const char *format, char *buffer, size_t length, int codepage)
 void log_rotate(const char *filename, int maxindex)
 {
     char buffer[2][MAX_PATH];
-    int dst = 1;
+    int err, dst = 1;
     assert(strlen(filename) < sizeof(buffer[0]) - 4);
 
     sprintf(buffer[dst], "%s.%d", filename, maxindex);
@@ -101,16 +101,17 @@ void log_rotate(const char *filename, int maxindex)
     remove(buffer[dst]);
 
     while (maxindex > 0) {
-        int err, src = 1 - dst;
+        int src = 1 - dst;
         sprintf(buffer[src], "%s.%d", filename, --maxindex);
         err = rename(buffer[src], buffer[dst]);
-        if (err != 0) {
-            fprintf(stderr, "log rotate %s: %s", buffer[dst], strerror(errno));
+        if ((err != 0) && (err != ENOENT)) {
+            fprintf(stderr, "log rotate %s: %d %s", buffer[dst], errno, strerror(errno));
         }
         dst = src;
     }
-    if (rename(filename, buffer[dst]) != 0) {
-        fprintf(stderr, "log rotate %s: %s", buffer[dst], strerror(errno));
+    err = rename(filename, buffer[dst]);
+    if ((err != 0) && (err != ENOENT)) {
+        fprintf(stderr, "log rotate %s: %d %s", buffer[dst], errno, strerror(errno));
     }
 }
 

From c5d266ff72a10c3cfc73cdf6223c0bf8642fe3d8 Mon Sep 17 00:00:00 2001
From: Enno Rehling <enno@kn-bremen.de>
Date: Fri, 5 Aug 2016 22:15:41 +0200
Subject: [PATCH 2/2] better defaults for logging to file and stderr.
 https://bugs.eressea.de/view.php?id=2224

---
 src/main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/main.c b/src/main.c
index 4285df150..ba1241564 100644
--- a/src/main.c
+++ b/src/main.c
@@ -152,7 +152,9 @@ static int verbosity_to_flags(int verbosity) {
 
 static int parse_args(int argc, char **argv, int *exitcode)
 {
-    int i, log_stderr = 0, log_flags = 0;
+    int i;
+    int log_stderr = LOG_CPERROR;
+    int log_flags = LOG_CPERROR | LOG_CPWARNING | LOG_CPINFO;
 
     for (i = 1; i != argc; ++i) {
         char *argi = argv[i];