Marc/server
1
0
Fork 0
forked from github/server
Code Issues Pull requests Projects Releases Wiki Activity

do not transfer migrants. comments are good.

Browse source
This commit is contained in:
Enno Rehling 2019-05-04 10:55:13 +02:00
parent 8605409ed3
commit 2cb4287268
2 changed files with 81 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
src/laws.c
View file

@ -964,22 +964,24 @@ void transfer_faction(faction *fsrc, faction *fdst) {
} }
for (u = fsrc->units; u != NULL; u = u->nextF) { for (u = fsrc->units; u != NULL; u = u->nextF) {
if (give_unit_allowed(u) == 0) { if (u_race(u) == fdst->race) {
if (u->skills) { if (give_unit_allowed(u) == 0) {
int i; if (u->skills) {
int i;
for (i = 0; i != u->skill_size; ++i) { for (i = 0; i != u->skill_size; ++i) {
const skill *sv = u->skills + i; const skill *sv = u->skills + i;
skill_t sk = (skill_t)sv->id; skill_t sk = (skill_t)sv->id;
if (skill_count[sk] + u->number > skill_limit[sk]) { if (skill_count[sk] + u->number > skill_limit[sk]) {
break; break;
}
}
if (i != u->skill_size) {
continue;
} }
} }
if (i != u->skill_size) { u_setfaction(u, fdst);
continue;
}
} }
u_setfaction(u, fdst);
} }
} }
} }

67
src/laws.test.c
View file

@ -1891,6 +1891,9 @@ static void test_quit(CuTest *tc) {
test_teardown(); test_teardown();
} }
/**
* Gifting units to another faction upon voluntary death (QUIT).
*/
static void test_quit_transfer(CuTest *tc) { static void test_quit_transfer(CuTest *tc) {
faction *f1, *f2; faction *f1, *f2;
unit *u1, *u2; unit *u1, *u2;
@ -1912,6 +1915,12 @@ static void test_quit_transfer(CuTest *tc) {
test_teardown(); test_teardown();
} }
/**
* Gifting units with limited skills to another faction.
*
* This is allowed only up to the limit of the target faction.
* Units that would break the limit are not transferred.
*/
static void test_quit_transfer_limited(CuTest *tc) { static void test_quit_transfer_limited(CuTest *tc) {
faction *f1, *f2; faction *f1, *f2;
unit *u1, *u2; unit *u1, *u2;
@ -1946,6 +1955,62 @@ static void test_quit_transfer_limited(CuTest *tc) {
test_teardown(); test_teardown();
} }
/**
* Only units of the same race can be gifted to another faction.
*/
static void test_quit_transfer_migrants(CuTest *tc) {
faction *f1, *f2;
unit *u1, *u2;
region *r;
test_setup();
r = test_create_plain(0, 0);
f1 = test_create_faction(NULL);
faction_setpassword(f1, "password");
u1 = test_create_unit(f1, r);
f2 = test_create_faction(NULL);
u2 = test_create_unit(f2, r);
contact_unit(u2, u1);
u1->thisorder = create_order(K_QUIT, f1->locale, "password %s %s",
LOC(f1->locale, parameters[P_FACTION]), itoa36(f2->no));
u_setrace(u1, test_create_race("smurf"));
quit_cmd(u1, u1->thisorder);
CuAssertIntEquals(tc, FFL_QUIT, f1->flags & FFL_QUIT);
CuAssertPtrEquals(tc, f1, u1->faction);
test_teardown();
}
/**
* Heroes cannot be gifted to another faction.
*/
static void test_quit_transfer_hero(CuTest *tc) {
faction *f1, *f2;
unit *u1, *u2;
region *r;
test_setup();
r = test_create_plain(0, 0);
f1 = test_create_faction(NULL);
faction_setpassword(f1, "password");
u1 = test_create_unit(f1, r);
f2 = test_create_faction(NULL);
u2 = test_create_unit(f2, r);
contact_unit(u2, u1);
u1->thisorder = create_order(K_QUIT, f1->locale, "password %s %s",
LOC(f1->locale, parameters[P_FACTION]), itoa36(f2->no));
u1->flags |= UFL_HERO;
quit_cmd(u1, u1->thisorder);
CuAssertIntEquals(tc, FFL_QUIT, f1->flags & FFL_QUIT);
CuAssertPtrEquals(tc, f1, u1->faction);
test_teardown();
}
CuSuite *get_laws_suite(void) CuSuite *get_laws_suite(void)
{ {
CuSuite *suite = CuSuiteNew(); CuSuite *suite = CuSuiteNew();
@ -2024,6 +2089,8 @@ CuSuite *get_laws_suite(void)
SUITE_ADD_TEST(suite, test_quit); SUITE_ADD_TEST(suite, test_quit);
SUITE_ADD_TEST(suite, test_quit_transfer); SUITE_ADD_TEST(suite, test_quit_transfer);
SUITE_ADD_TEST(suite, test_quit_transfer_limited); SUITE_ADD_TEST(suite, test_quit_transfer_limited);
SUITE_ADD_TEST(suite, test_quit_transfer_migrants);
SUITE_ADD_TEST(suite, test_quit_transfer_hero);
return suite; return suite;
} }