From 1df0afc58a49d49ea9571dce8d866a57b7a58e40 Mon Sep 17 00:00:00 2001 From: Enno Rehling Date: Fri, 30 Oct 2015 12:50:32 +0100 Subject: [PATCH] CID 22550: Dereference before null check (REVERSE_INULL) --- src/give.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/give.c b/src/give.c index f9879b9dd..6d1d525e8 100644 --- a/src/give.c +++ b/src/give.c @@ -289,7 +289,7 @@ message * give_men(int n, unit * u, unit * u2, struct order *ord) else { if (n > u->number) n = u->number; - if (u2 && n + u2->number > UNIT_MAXSIZE) { + if (n + u2->number > UNIT_MAXSIZE) { n = UNIT_MAXSIZE - u2->number; ADDMSG(&u->faction->msgs, msg_feedback(u, ord, "error_unit_size", "maxsize", UNIT_MAXSIZE));